This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Return focus to the active tab's content area after dismissal of notifications and/or message boxes #15130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring menu
fixes empty ad containers on yahoo.com
Update master to 0.25.0
Fix some error branches in tor controller logic.
This should address the failure reported in: #14675 (comment) fix #14630 Auditors: @diracdeltas Test Plan: see #14630
This, and TorControl.destroy(), are worth making idempotent because errors may happen synchronously _or_ asynchronously, so there are two levels at which a caller might want to clean up. For example, authentication failure is reported as a 515 error from tor, _and_ the tor daemon will close the control connection leading to an asynchronous error.
There is no way to know exactly when this might happen, alas: readables and writables don't necessarily emit their close events promptly.
for some reason, the windows path has an extra `../` prefix compared to mac so the favicon doesn't load. this works around the issue by removing a `../` on windows. Test Plan: 1. open new tab 2. hit `:g` in the urlbar 3. the search favicon should load on all platforms
…es-v2 Fix some more error branches, assert sanity, and automatically test it all.
This was always signing the RPM because the test was failing, now we will test and if the signature exists then move on. The error seen was: tools/upload_to_rpm_repo: line 18: !rpm: command not found
fix search favicon path on windows
…ut key for new private tab Fixes #14504 Auditors: @diracdeltas
Fix #14680 Test Plan: 1. open brave, turn on showing bookmarks toolbar and showing home button in about:preferences. bookmark some sites. 2. open tor tab and try to click on bookmarks before tor finishes loading. also try clicking on the home button and clicking the History > Home menu item. 3. these loads should be blocked until tor finishes initializing
Add shortcut for private tab with Tor and also update existing shortc…
Allow upload script to check if current signature exists.
Block tab.loadURL in tor tabs until tor is initialized
fix #14653 for some reason, renaming the searx favicon to something that doesn't have 'searx' in the filename makes it reappear Test Plan: 1. make a packaged build 2. open brave 3. hit ':x' in urlbar. searx favicon should appear.
Fix mysterious searx favicon disappearing in builds
Update to Muon 7.1.6
To do this, we separate step of killing the daemon and control channel from the step of ceasing to watch for updates. On errors, we want to kill the daemon and control channel, but continue watching for updates in case the daemon restarts. Possible snag: we do not rate-limit failures if they are recursive. Not currently an issue but we should take care of this in the future.
fix #14431 Auditors: @diracdeltas @bsclifton Test Plan: I: 1. Open a tab _without_ Tor (private or nonprivate). 2. Enter: https://nyttips4bmquxfzw.onion/ 3. Confirm that Brave blocks loading the URL. II: 1. Open a tab _without_ Tor (private or nonprivate). 2. Enter: https://nyttips4bmquxfzw.onion:12345/ 3. Confirm that Brave blocks loading the URL. III: 1. Open a private tab with Tor. 2. Enter: https://nyttips4bmquxfzw.onion/ 3. Confirm that the NYT SecureDrop page loads. 4. Bookmark it. 5. Open a tab _without_ Tor (private or nonprivate). 6. Try to load the bookmark. 7. Confirm that Brave blocks loading the bookmark.
Don't emit an 'error' event if we did pass them synchronously. Establish an 'error' handler in filtering.js for asynchronous errors.
eth-wallet: 'enable brave payments' notice
potential fix for #14667
This reverts commit 22f4cc8. Revert "Merge pull request #15033 from ryanml/fix-15031" This reverts commit 16a7383. Revert "Merge pull request #15032 from ryanml/fix-15023" This reverts commit ee4df6f. Revert "Merge pull request #15034 from brave/static-nodes-dir" This reverts commit cd37100. Revert "Merge pull request #15029 from brave/geth-sanity-updates" This reverts commit 84b416b. Revert "Merge pull request #15022 from brave/deleteDidDetach" This reverts commit c209fbd. Revert "Merge pull request #15027 from Slava/eth-wallet-password" This reverts commit c1d1fe9. Revert "Merge pull request #14734 from Slava/feature/ethwallet" This reverts commit 72820e8.
Revert ETH Wallet functionality
fix #15045 Test Plan: DM'ed
second fix for URL open in new tab
Resolves #14980
Use v2 promotion endpoints
Don't consider openableByContextMenu if URL is falsey
Resolves #15067 Auditors: Test Plan:
Removes delay for referral
fix #15074 Test Plan: DM'ed
block chrome://brave URL loads
Fixes #15075 Auditors: @diracdeltas
Allow `view-source` as openable by context menu
Resolves #15073 Auditors: Test Plan:
Removes shadow
fix typo in test description: deafult -> default
fix typo in js extension comment: occuring -> occurring
Release notes for 0.23.x Release 5
fixed tabs / spaces in messageBox / notificationItem files
|
Thanks for the patch, @rederekt 😄 I'm going to close this PR though, as we are in the middle of migrating from one code-base to another You can check out our new repo here: and you can check out a developer channel release here: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
For notifications
Open a new instance of Brave. Go to google.com and searched for something, e.g. "Brave". In my case, I got a notification asking me if I wanted Google to remember my location. I dismissed the notification. To test focus, hit the down arrow key, and the page should scroll through results when it didn't before.
For text boxes
Open the console with Opt+Cmd+I (on Mac). type `alert("hello");" into the console. Dismiss the popup, then try the same "down arrow key" test used above.
Reviewer Checklist:
Tests