Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

second fix for URL open in new tab #15047

Merged
merged 1 commit into from
Aug 17, 2018
Merged

second fix for URL open in new tab #15047

merged 1 commit into from
Aug 17, 2018

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Aug 16, 2018

fix #15045

Test Plan:
DM'ed

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! I double checked to make the urlParse call is wrapped in a try/catch 😄(in the underlying implementation). Huge thanks for the tests 🥇

@bsclifton bsclifton merged commit 9e3bf36 into master Aug 17, 2018
@bsclifton bsclifton deleted the fix/15045 branch August 17, 2018 06:42
bsclifton added a commit that referenced this pull request Aug 17, 2018
second fix for URL open in new tab
bsclifton added a commit that referenced this pull request Aug 17, 2018
second fix for URL open in new tab
bsclifton added a commit that referenced this pull request Aug 17, 2018
second fix for URL open in new tab
@bsclifton
Copy link
Member

master 9e3bf36
0.24.x 2007f33
0.23.x 9c24d36
0.23.x-release5 70c7bb9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hackerone] chrome:// new tab issue
2 participants