Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

opening tabs, PT, session tabs opens about:blank when there's no Win/Tabs opened #15162

Closed
kjozwiak opened this issue Sep 6, 2018 · 2 comments · Fixed by #15194
Closed

opening tabs, PT, session tabs opens about:blank when there's no Win/Tabs opened #15162

kjozwiak opened this issue Sep 6, 2018 · 2 comments · Fixed by #15194
Assignees
@diracdeltas
Labels
OS/macOS QA/checked-macOS QA/test-plan-specified regression release-notes/include
Milestone
0.24.0 - Chromium...

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Sep 6, 2018 •
edited by bsclifton
Loading

Test plan

See #15194

Description

When opening any type of tabs or new windows via the File Menu on macOS when there's nothing else opened but Brave is still the active application, you'll get about:blank rather than about:newtab pages. Assuming it's because of either #15045 or #15047.

Steps to Reproduce

  1. open brave via macOS and close all windows (keep brave as the active application)
  2. select File -> New Tab and you'll get about:blank

Can reproduce the above using:

  • File -> New Private Tab
  • File -> New Private Tab with Tor
  • File -> New Session Tab

Actual result:

Opening about:blank pages rather than about:newtab pages.

Expected result:

Should be opening about:newtab and not about:blank

Reproduces how often:

100% reproducible using the above STR mentioned above.

Brave Version

about:brave info:

Brave: 0.23.204 
V8: 6.9.427.19 
rev: a9a7e9ce52e4b35041e0245544298b7431ba7d9c 
Muon: 8.1.3 
OS Release: 17.7.0 
Update Channel: Beta 
OS Architecture: x64 
OS Platform: macOS 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 69.0.3497.81

Reproducible on current live release:

Yes, currently reproducible under the following build which is the current live build:

Brave: 0.23.105 
V8: 6.8.275.24 
rev: 9a46f8f5cb22a9daf2af21989aed25911aa6f839 
Muon: 8.0.9 
OS Release: 17.7.0 
Update Channel: Release 
OS Architecture: x64 
OS Platform: macOS 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 68.0.3440.84

Additional Information

  • 0.23.105 9a46f8f <-- Reproducible
  • 0.23.104 b454a4a <-- Reproducible
  • 0.23.79 51b4905 <-- Couldn't reproduce

Reproduced by @LaurenWags as well.
@diracdeltas diracdeltas self-assigned this Sep 12, 2018
diracdeltas added a commit that referenced this issue Sep 12, 2018
@diracdeltas
Fix about:blank appearing on new tab in new windows
602f1aa 
fix #15162

openableByContextMenu returned false if URL is empty for paranoia
reasons, but it turns out this breaks some edge cases. See
#15061 for instance.

Test Plan:
1. unit tests pass
2. on MacOS, close all windows
3. click 'open in new tab'
4. new window should appear and show the new tab page
5. repeat step 3 and 4 with private tab, tor tab, session tab
@diracdeltas diracdeltas mentioned this issue Sep 12, 2018
Merged
10 tasks
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Sep 14, 2018
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Sep 14, 2018 •
edited by kjozwiak
Loading

Verified with macOS 10.12.6 using

  • 0.23.206 80a5ac1
  • Muon 8.1.5
  • libchromiumcontent 69.0.3497.92

Verified with macOS 10.13.6 x64 using the following build:

  • 0.23.206 80a5ac1
  • Muon: 8.1.5
  • libchromiumcontent: 69.0.3497.92

@kjozwiak
Copy link
Member Author

+1 from https://community.brave.com/t/with-no-open-window-links-from-external-apps-dont-open/32467/

@kjozwiak kjozwiak mentioned this issue Sep 19, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
OS/macOS QA/checked-macOS QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.24.0 - Chromium 69 (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fix about:blank appearing on new tab in new windows brave/browser-laptop
4 participants
@diracdeltas @kjozwiak @bsclifton @LaurenWags