Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Allow view-source as openable by context menu #15078

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Allow view-source as openable by context menu #15078

merged 1 commit into from
Aug 22, 2018

Conversation

bsclifton
Copy link
Member

Fixes #15075

Auditors: @diracdeltas

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. Visit https://brave.com
  2. Right click the page, pick View Page Source. Ensure page source comes up. Close it
  3. Manually type a view source URL into URL bar: view-source:https://clifton.io. Ensure page source comes up. Close it
  4. Make a new bookmark for view-source:https://brianbondy.com/ and launch the bookmark. Ensure page source comes up

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton self-assigned this Aug 22, 2018
@bsclifton bsclifton requested a review from diracdeltas August 22, 2018 21:28
@bsclifton bsclifton merged commit 75b8cda into brave:master Aug 22, 2018
@bsclifton bsclifton deleted the fix-view-source branch August 22, 2018 21:38
bsclifton added a commit that referenced this pull request Aug 22, 2018
Allow `view-source` as openable by context menu
bsclifton added a commit that referenced this pull request Aug 22, 2018
Allow `view-source` as openable by context menu
@bsclifton
Copy link
Member Author

master 75b8cda
0.24.x 48841b1
0.23.x 18efca1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants