Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

delete did-detach block accidentally brought back in #14734 #15022

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

evq
Copy link
Member

@evq evq commented Aug 14, 2018

fixes #15019

a block removed in the single webview project was added back in due to a rebase issue

see discussion here:
https://github.com/brave/browser-laptop/pull/14734/files#r202442461

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@evq evq requested a review from petemill August 14, 2018 19:35
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this

@petemill
Copy link
Member

I'll merge to master, 0.24, and 0.23 when the CI test finishes

@petemill petemill merged commit d8c52a4 into master Aug 15, 2018
petemill added a commit that referenced this pull request Aug 15, 2018
delete did-detach block accidentally brought back in #14734
petemill added a commit that referenced this pull request Aug 15, 2018
delete did-detach block accidentally brought back in #14734
@petemill
Copy link
Member

0.24.x c209fbd
0.23.x b433bc2

@petemill petemill deleted the deleteDidDetach branch August 15, 2018 23:00
@bsclifton bsclifton mentioned this pull request Aug 16, 2018
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Issue: tab.detatch
3 participants