Skip to content

[Android Tablet] Implement Contribution Banner 3.0 for Tablet #30371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Miyayes opened this issue May 16, 2023 · 1 comment · Fixed by brave/brave-core#20223
Closed

[Android Tablet] Implement Contribution Banner 3.0 for Tablet #30371

Miyayes opened this issue May 16, 2023 · 1 comment · Fixed by brave/brave-core#20223
Assignees
Labels
android-tablet-specific feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android Tab QA/Yes release-notes/include

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented May 16, 2023

Description

Tablet part of #28149.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 17, 2023

Verification PASSED on Samsung Galaxy Tab A7 version 12 running Bravemonoarm64.apk_1.61.67

User State 3: Connected - PASSED
  • When the tip panel is opened,
    • The user's BAT balance for their provider should be displayed.
Example Example
Screenshot_20231117-220336_Brave - Beta Screenshot_20231117-203420_Brave - Beta
  • When the tip panel is opened and the user is logged out from their wallet provider,
    • A login message should be displayed,
    • And a "Log In" button should be displayed that will take the user to the wallet provider's authorization URL.
Uphold Dark Uphold Light Gemini Dark Gemini Light bitFlyer Dark bitFlyer Light
Screenshot_20231117-221506_Brave - Beta Screenshot_20231117-221445_Brave - Beta Screenshot_20231220-145429_Brave - Beta Screenshot_20231220-145345_Brave - Beta Screenshot_20231120-165545_Brave - Beta Screenshot_20231120-165520_Brave - Beta
  • When the tip panel is opened and the publisher does not have the same wallet provider as the user,
    • A "mismatch" message should be displayed.
Uphold Dark Uphold Light Gemini Dark Gemini Light bitFlyer Dark bitFlyer Light
Screenshot_20231117-221135_Brave - Beta Screenshot_20231117-221114_Brave - Beta Screenshot_20231220-143938_Brave - Beta Screenshot_20231220-144154_Brave - Beta Screenshot_20231220-163019_Brave - Beta Screenshot_20231220-163040_Brave - Beta
  • When "Send" is clicked with a valid amount,
    • The tip should be sent and the success UI should be displayed,
    • And the "Share" button should open Twitter with a "new post" prompt.
Success Dark UI Tweet from Dark UI Success Light UI Tweet from Light UI
Screenshot_20231117-221803_Brave - Beta Screenshot_20231117-222203_Brave - Beta Screenshot_20231117-222306_Brave - Beta Screenshot_20231117-222324_Brave - Beta
  • When "Send" is clicked and the monthly toggle is set,
    • A one-time tip should be sent,
    • And the success UI should be displayed
    • And a monthly contribution should be added to the "Monthly Contributions" list visible on the Rewards page.
Example Example Example Example Example
Screenshot_20231117-222306_Brave - Beta Screenshot_20231117-222354_Brave - Beta Screenshot_20231117-222409_Brave - Beta Screenshot_20231117-222418_Brave - Beta Screenshot_20231117-222447_Brave - Beta
  • When the tip panel is opened and a monthly contribution is already set for the publisher,
    • The tip panel should display a message indicating that a monthly contribution is already set.
Dark UI panel Light UI banner
Screenshot_20231117-222606_Brave - Beta Screenshot_20231117-222354_Brave - Beta
  • Advanced my computer clock to next monthly contribution date (Jun 12 per Monthly Contributions section of brave://rewards
    • Confirmed monthly tip was sent as expected
    • Confirmed next monthly tip was scheduled per Monthly Contributions section of brave://rewards)
Example Example Example Example
Screenshot_20231220-195848_Brave - Beta Screenshot_20231220-195858_Brave - Beta Screenshot_20231220-195919_Brave - Beta Screenshot_20231220-195841_Brave - Beta
  • When the Rewards panel is opened for an unverified publisher,
    • A message should be displayed stating that the publisher is not verified,
    • And the "Send Contribution" button should be disabled.
Dark Light
Screenshot_20231220-152259_Brave - Beta Screenshot_20231220-152315_Brave - Beta
  • When the Rewards panel is opened for a verified publisher,
    • The "Send Contribution" button should be enabled.
Dark Light
Screenshot_20231220-152410_Brave - Beta Screenshot_20231220-152351_Brave - Beta
  • When an in-line tip icon is clicked for an unverified publisher, - NA
    • The Rewards panel should be opened with a message indicating the publisher is not verified,
    • And the "Send Contribution" button should be disabled.

Note : There is no inline tip icon in RC 1.52.x and 1.53.x for the github/reddit/twitter pubs

  • When an in-line tip icon is clicked for a verified publisher, - NA
    • The tip panel should be opened.

Note : There is no inline tip icon in RC 1.52.x and 1.53.x for the github/reddit/twitter pubs

  • When an error is encountered when creating a transaction with the wallet provider.
    • An error message should be displayed,
    • And a "Try Again" button should be displayed.
custodian Dark custodian Light
Screenshot_20231220-161556_Brave - Beta Screenshot_20231220-161911_Brave - Beta
Additional tests - PASSED
  1. Confirm when a monthly tip is configured for a creator, a one time tip can still be sent:
  • Fresh profile, close and relaunch to pull griffin
  • Join rewards, connect a custodian
  • Navigate to a creator who is verified with your same custodian
  • Set up a monthly tip
  • Confirm tip is sent immediately and one is scheduled for next month
  • Open tip banner for that same creator, see message about monthly contribution
  • Send another tip
  • Confirm tip is sent
Example Example Example Example Example Example
Screenshot_20231120-204736_Brave - Beta Screenshot_20231120-204811_Brave - Beta Screenshot_20231120-204832_Brave - Beta Screenshot_20231120-204842_Brave - Beta Screenshot_20231120-204900_Brave - Beta Screenshot_20231120-204922_Brave - Beta
  1. Confirm no more hover text on panel:
  • Fresh profile, close and relaunch to pull griffin
  • Join rewards, connect a custodian
  • Navigate to a creator who is verified with a different custodian than you
  • Example, I have an Uphold wallet and navigated to a Gemini creator
  • Confirm on the panel, there is no hover text when you hover over "Verified creator"
  • Confirm when you select "Send Contribution" button, the contribution/tip banner shows a message about this creator and you are unable to tip them
Example Example
Screenshot_20231120-205148_Brave - Beta Screenshot_20231120-205202_Brave - Beta
  1. Rounded corners - NA
  • Confirm tip banner has rounded corners

In android tip panels are already rounded

Example Example
Screenshot_20231120-205240_Brave - Beta Screenshot_20231120-205301_Brave - Beta
  1. Confirm when clicking in-line tip button on twitter for a verified creator, that the tip banner no longer quotes the tweet

Note: there is no inline tip icon in RC 1.52.x and 1.53.x github/reddit/twitter pubs for grandfathered unconnected state

  1. Pending Contributions - not tested, will be covered in future issues when Pending Contributions code is removed
Figma - PASSED
  1. From the "Contribution Banner/Android" section
  • The following from Figma were generally covered during testing of "User State 3 - Connected" with various sites:

    • Custom vs Standard/default images
    • Click away from banner to close it
    • Contribution sent icon/message
    • Light and dark modes
    • Custom amount entry
  • The following from this section of Figma are shown below:

    • Verified creator icon hover text
    • switch between BAT and USD
    • Monthly Contribution tooltip
Creator icon hover (dark) Creator icon hover (light) BAT/USD switch BAT/USD switch Monthly tooltip (dark) Monthly tooltip (light)
Screenshot_20231120-210303_Brave - Beta Screenshot_20231120-210330_Brave - Beta Screenshot_20231120-210414_Brave - Beta Screenshot_20231120-210456_Brave - Beta Screenshot_20231120-210545_Brave - Beta Screenshot_20231120-210607_Brave - Beta
  1. From the "Contribution Banner Error/Info States, User can continue" section - all of these were verified under "User State 3 - Connected"
  • User is already sending monthly tips
Dark UI banner Light UI banner
Screenshot_20231120-210735_Brave - Beta Screenshot_20231120-210751_Brave - Beta
  • Creator has different custodian than user, covered the testing in User State 3: Connected case

  • Creator verified - custodian but no web3 wallet (wording of this is incorrect on the figma)
    User State 3: Connected case

Dark UI banner Light UI banner
Screenshot_20231120-210905_Brave - Beta Screenshot_20231120-210923_Brave - Beta
  • User is logged out of their custodian account

covered the testing in User State 3: Connected case

  • Contribution failure

covered the testing in User State 3: Connected case

  1. From the "Contribution Banner Error/Info States, user dead end" section
  • The following from Figma were generally covered during testing of the various user states (1-4):
    - Creator not registered (panel)
Dark Light
Screenshot_20231120-211039_Brave - Beta Screenshot_20231120-211011_Brave - Beta
  - Custodian is not connected to Rewards (panel)
Dark Light
Screenshot_20231120-211423_Brave - Beta Screenshot_20231120-211447_Brave - Beta
  - No custodian available in region (panel)
Dark Light
Screenshot_20231120-211555_Brave - Beta Screenshot_20231120-211539_Brave - Beta
  - User doesn't have enough tokens for transaction
Dark Light
Screenshot_20231120-211147_Brave - Beta Screenshot_20231120-211225_Brave - Beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-tablet-specific feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android Tab QA/Yes release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants