Skip to content

[Android] - Terms of service and Privacy policy text is not shown in Dark theme in both Tablet and Android ARM #34417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeetaSarvadnya opened this issue Nov 17, 2023 · 3 comments · Fixed by brave/brave-core#21215
Assignees
Labels
feature/rewards feature/user-interface All UI related OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 17, 2023

Description

Found while testing #30371
Terms of service and Privacy policy text is not shown in Dark theme in both Tablet and Android ARM

Steps to reproduce

  1. Clean profile 1.61.67
  2. Enable rewards and connect bitFlyer custodian
  3. Change theme to Dark mode via appearance settings in hambuger menu
  4. Open Alexvincentmusic.com pubs
  5. Open Tipping banner

Actual result

Terms of service and Privacy policy text is not shown in Dark theme in both Tablet and Android ARM
image

Expected result

Terms of service and Privacy policy text color needs to be changed in Dark theme

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): All
  • Device type (Phone, Tablet, Phablet): All
  • Android version: 12

Brave version

1.61.67

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/qa-team @deeppandya @Miyayes

@kjozwiak
Copy link
Member

kjozwiak commented Dec 5, 2023

The above requires 1.61.98 or higher for 1.61.x verification 👍

@LaurenWags
Copy link
Member

Confirmed release-notes/exclude label with @Miyayes

@GeetaSarvadnya
Copy link
Author

Verification PASSED on Samsung galaxy Tab A7 version 12 running Bravemonoarm64.apk_1.61.98

  • Verified the STR from the description and ensured that the Terms of service and Privacy policy text is shown in the Dark theme
Dark them Light theme
Screenshot_20231206-162050_Brave Screenshot_20231206-161920_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards feature/user-interface All UI related OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants