Skip to content

improve the design of the tipping banner on tablet devices #27252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kjozwiak opened this issue Dec 8, 2022 · 3 comments
Closed

improve the design of the tipping banner on tablet devices #27252

kjozwiak opened this issue Dec 8, 2022 · 3 comments
Assignees
Labels
design A design change, especially one which needs input from the design team feature/rewards OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Dec 8, 2022

Description

As per the discussion via https://bravesoftware.slack.com/archives/C03MMJ4CHEZ/p1670530053373799, we should improve the tipping banner UX/UI on tablet devices. With the current implementation, there's a lot of wasted space which creates UX/UI isses like the one describe via #27251. You'll notice that all the buttons are spread pretty far apart or are oversized.

@brave/design-team @anatolydsgn please feel free to update the issue to add examples/designs etc..

Steps to reproduce

  1. install brave that has Show close button in tipping banner brave-core#16081 (used 1.48.24 Chromium: 108.0.5359.71)
  2. enable staging via Hamburger Menu -> Settings -> Developer options
  3. restart the browser and enable rewards via the rewards panel (accept the ~30 BAT ads grant)
  4. visit https://laurenwags.github.io and tap on the BAT icon (initiate a tip so the tipping banner is visible)

Actual result

Screenshot_20221208_145312_Brave - Nightly

Expected result

We should improve the general UI of the tipping banner on tablet devices to improve users experience.

Issue reproduces how often

100% reproducible when using the STR/Cases outlined above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

This will be on Release once we push out the 1.46.x maintenance release.

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung Galaxy Tab S8 Ultra (Tablet)
  • Android version: Android 13

Brave version

Brave | 1.48.24 Chromium: 108.0.5359.71 (Official Build) canary (32-bit)
--- | ---
Revision | 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS | Android 13; Build/TP1A.220624.014

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

@kjozwiak kjozwiak added design A design change, especially one which needs input from the design team feature/rewards QA/Yes OS/Android Fixes related to Android browser functionality labels Dec 8, 2022
@Miyayes Miyayes added the priority/P4 Planned work. We expect to get to it "soon". label Dec 14, 2022
@anatolydsgn
Copy link

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 9, 2023

Let's go with:
image

@Miyayes
Copy link
Collaborator

Miyayes commented May 16, 2023

Will be resolved by #30371.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/rewards OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Projects
None yet
Development

No branches or pull requests

4 participants