Skip to content

[Tablet] "Contribution sent!" bottom sheet banner stretched out on the tablets #32067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hffvld opened this issue Aug 3, 2023 · 2 comments
Closed
Labels

Comments

@hffvld
Copy link
Contributor

hffvld commented Aug 3, 2023

Description

Contribution sent! bottom sheet banner stretched out on the tablets

Steps to reproduce

  1. Launch Brave on a Tablet
  2. Enable Rewards Staging server
  3. Enable Rewards and connect Custodian
  4. Open https://github.com/laurenwags > Send contribution > Observe Contribution sent! bottom sheet banner is stretched out

Actual result

Contribution sent! bottom sheet banner stretched out on the tablets. This is not happening on the phones.

1
1

Expected result

Contribution sent! bottom sheet banner must not be stretched out.

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Galaxy Tab S8 (Tablet)
  • Android version: Android 13

Brave version

Brave build: 1.58.66
Chromium: 116.0.5845.51 (Official Build) canary (64-bit)
Revision: 760f994

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@hffvld hffvld added OS/Android Fixes related to Android browser functionality bug feature/rewards QA/Yes android-tablet-specific labels Aug 3, 2023
@Miyayes
Copy link
Collaborator

Miyayes commented Aug 4, 2023

@sujitacharya2005 I think the tablet-specific implementation of the Contribution Banner will solve this, right?

@deeppandya
Copy link
Contributor

deeppandya commented Aug 4, 2023

it would be resolved as a part of #30371

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants