Rewards tipping tablet UI #20223

sujitacharya2005 · 2023-09-19T19:45:56Z

Submitter Checklist:

I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Tablet Light	Tablet Dark	Mobile Light	Mobile Dark

sujitacharya2005 · 2023-09-25T21:24:17Z

cc : @Miyayes
Please review this

deeppandya · 2023-09-26T16:27:12Z

android/java/org/chromium/chrome/browser/rewards/tipping/PopupWindowTippingTabletUI.java

+    @Override
+    public void onResume() {
+        super.onResume();
+


nit : we can remove the new line here.

deeppandya · 2023-09-26T16:29:01Z

android/java/org/chromium/chrome/browser/rewards/tipping/PopupWindowTippingTabletUI.java

+
+        WindowManager.LayoutParams params = window.getAttributes();
+        boolean isLandscape = ConfigurationUtils.isLandscape(getActivity());
+        if (isLandscape) {


we can similar to below,
float widthRatio = isLandscape ? 0.8 : 0.96;
params.width = (int) (widthRatio*mDeviceWidth);

deeppandya · 2023-09-26T16:30:15Z

android/java/org/chromium/chrome/browser/rewards/tipping/RewardsTippingBannerFragment.java

+import androidx.appcompat.app.AppCompatActivity;
+import androidx.fragment.app.Fragment;
+
+import com.bumptech.glide.Glide;


Can we remove glide usage here ? we need to move away from glide at some point so it's better to remove any usage we have.

This code is old, just moved from activity to fragment.
Do you want to use ImageLoader here?
Last time I tested same thing Image Loader is very slow and caching is not working.
Filed issue : brave/brave-browser#30136
Please let me know if anything update happened in ImageLoader recently.

let's update it with ImageLoader and add details to the issue if we have any performance issues. so we can look into it separately.

Sure, I will implement ImageLoader, even it's slow and caching is not working.
I will update details in the issue..

@deeppandya
Now it's Updated with ImageLoader
https://github.com/brave/brave-core/assets/32419898/76905bc4-404e-4445-bf15-b06824fcbc3e

deeppandya · 2023-09-26T16:33:36Z

android/java/org/chromium/chrome/browser/rewards/tipping/RewardsTippingBannerFragment.java

+        }
+    }
+
+    private String getProvider(String provider) {


we can use android:inputType="textCapWords" for Textview instead of changing the text here.

This same logic is used in desktop side
PCDN data will contain normal word and need to map proper format like
youtube -> YouTube

in that case, is it possible to use the same function as desktop through mojom ?

It's not exposed , code is here
https://github.com/brave/brave-core/blob/master/components/brave_rewards/resources/shared/lib/publisher_platform.ts#L13

deeppandya · 2023-10-03T17:19:01Z

android/java/res/drawable-sw600dp/bottomsheet_rewards_tipping_success_background.xml

+        <shape>
+            <corners android:radius="28dp" />
+            <solid android:color="@color/rewards_background_gradient_end_color"/>
+


nit : remove extra new line

deeppandya · 2023-10-03T17:19:13Z

android/java/res/drawable/bottomsheet_rewards_background_tablet.xml

+                android:startX="90"
+                android:startY="254"
+                android:type="linear" />>
+


nit : remove extra new line

deeppandya · 2023-10-03T17:19:46Z

android/java/res/layout-sw600dp/rewards_tipping_banner_fragment.xml

+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:layout_gravity="center_horizontal">
+


nit : remove extra new line

deeppandya

LGTM

tapanmodh · 2023-10-03T19:14:18Z

android/java/res/drawable/bottomsheet_rewards_background_tablet.xml

+        </shape>
+    </item>
+</layer-list>
+


nit : remove extra new line

tapanmodh

LGTM

github-actions bot assigned sujitacharya2005 Sep 19, 2023

sujitacharya2005 marked this pull request as draft September 19, 2023 19:47

sujitacharya2005 force-pushed the 30371_rewards_tipping_tablet_ui branch 2 times, most recently from 30c3281 to 7b02948 Compare September 19, 2023 20:57

sujitacharya2005 added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Sep 19, 2023

sujitacharya2005 requested review from deeppandya and tapanmodh September 19, 2023 20:58

sujitacharya2005 marked this pull request as ready for review September 19, 2023 20:58

sujitacharya2005 force-pushed the 30371_rewards_tipping_tablet_ui branch from 7b02948 to 435978c Compare September 22, 2023 09:34

deeppandya requested a review from emerick September 22, 2023 18:28

sujitacharya2005 force-pushed the 30371_rewards_tipping_tablet_ui branch 3 times, most recently from 36ad97f to 656f0a1 Compare September 25, 2023 21:20

sujitacharya2005 force-pushed the 30371_rewards_tipping_tablet_ui branch from 656f0a1 to c629f63 Compare September 26, 2023 08:57

mihaiplesa removed CI/skip-linux-arm64 labels Sep 26, 2023

wknapik removed the CI/skip-windows-x86 label Sep 26, 2023

deeppandya suggested changes Sep 26, 2023

View reviewed changes

sujitacharya2005 force-pushed the 30371_rewards_tipping_tablet_ui branch from c629f63 to 9ddecfa Compare September 26, 2023 18:29

emerick approved these changes Sep 27, 2023

View reviewed changes

sujitacharya2005 force-pushed the 30371_rewards_tipping_tablet_ui branch 2 times, most recently from c8d5b1d to c743c3a Compare September 29, 2023 10:34

deeppandya self-requested a review October 3, 2023 17:13

deeppandya reviewed Oct 3, 2023

View reviewed changes

deeppandya approved these changes Oct 3, 2023

View reviewed changes

sujitacharya2005 force-pushed the 30371_rewards_tipping_tablet_ui branch from c743c3a to 0df6ff4 Compare October 3, 2023 18:36

tapanmodh reviewed Oct 3, 2023

View reviewed changes

android/java/res/drawable/bottomsheet_rewards_background_tablet.xml

</shape>

</item>

</layer-list>

Copy link

Contributor

tapanmodh Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : remove extra new line

tapanmodh approved these changes Oct 3, 2023

View reviewed changes

Rewards tipping tablet UI

8f40543

sujitacharya2005 force-pushed the 30371_rewards_tipping_tablet_ui branch from 0df6ff4 to 8f40543 Compare October 5, 2023 12:47

sujitacharya2005 added CI/skip-windows-x64 Do not run CI builds for Windows x64 and removed CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Oct 5, 2023

deeppandya merged commit 506948a into master Oct 6, 2023

deeppandya deleted the 30371_rewards_tipping_tablet_ui branch October 6, 2023 19:37

github-actions bot added this to the 1.61.x - Nightly milestone Oct 6, 2023

GeetaSarvadnya mentioned this pull request Nov 17, 2023

[Android Tablet] Implement Contribution Banner 3.0 for Tablet brave/brave-browser#30371

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewards tipping tablet UI #20223

Rewards tipping tablet UI #20223

sujitacharya2005 commented Sep 19, 2023 •

edited

Loading

sujitacharya2005 commented Sep 25, 2023

deeppandya Sep 26, 2023

sujitacharya2005 Sep 26, 2023

deeppandya Sep 26, 2023

sujitacharya2005 Sep 26, 2023

deeppandya Sep 26, 2023

sujitacharya2005 Sep 26, 2023

deeppandya Sep 26, 2023

sujitacharya2005 Sep 27, 2023

sujitacharya2005 Sep 29, 2023

deeppandya Sep 26, 2023

sujitacharya2005 Sep 26, 2023

deeppandya Sep 26, 2023

sujitacharya2005 Sep 27, 2023

deeppandya Oct 3, 2023

deeppandya Oct 3, 2023

deeppandya Oct 3, 2023

deeppandya left a comment

tapanmodh Oct 3, 2023

tapanmodh left a comment

Rewards tipping tablet UI #20223

Rewards tipping tablet UI #20223

Conversation

sujitacharya2005 commented Sep 19, 2023 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

sujitacharya2005 commented Sep 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deeppandya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tapanmodh left a comment

Choose a reason for hiding this comment

sujitacharya2005 commented Sep 19, 2023 •

edited

Loading