Skip to content

New Crowdin updates #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

New Crowdin updates #111

wants to merge 29 commits into from

Conversation

brave-support-admin
Copy link
Contributor

No description provided.

@brave-support-admin brave-support-admin requested a review from a team as a code owner March 13, 2025 08:49
tmancey
tmancey previously approved these changes Mar 13, 2025
Copy link

The following commits were not verified:
479e435 (unsigned)
7bcd306 (unsigned)
06c59cb (unsigned)
d5d4210 (unsigned)
a0e6d67 (unsigned)
7c091d7 (unsigned)
d4f2205 (unsigned)
50f2b75 (unsigned)
01a0251 (unsigned)
5505dd0 (unsigned)
40098db (unsigned)
41cf764 (unsigned)
bb3e5ff (unsigned)
4a90516 (unsigned)
0fb784e (unsigned)
f734cbd (unsigned)
b578b60 (unsigned)
b48daa6 (unsigned)
65e142f (unsigned)
ec1a50f (unsigned)
a185853 (unsigned)
fffa0b4 (unsigned)
7bf7e43 (unsigned)
4acc740 (unsigned)
871ddc3 (unsigned)
5ec13d1 (unsigned)
e5f6994 (unsigned)
b9cc5b6 (unsigned)
dcb06cd (unsigned)

1 similar comment
Copy link

The following commits were not verified:
479e435 (unsigned)
7bcd306 (unsigned)
06c59cb (unsigned)
d5d4210 (unsigned)
a0e6d67 (unsigned)
7c091d7 (unsigned)
d4f2205 (unsigned)
50f2b75 (unsigned)
01a0251 (unsigned)
5505dd0 (unsigned)
40098db (unsigned)
41cf764 (unsigned)
bb3e5ff (unsigned)
4a90516 (unsigned)
0fb784e (unsigned)
f734cbd (unsigned)
b578b60 (unsigned)
b48daa6 (unsigned)
65e142f (unsigned)
ec1a50f (unsigned)
a185853 (unsigned)
fffa0b4 (unsigned)
7bf7e43 (unsigned)
4acc740 (unsigned)
871ddc3 (unsigned)
5ec13d1 (unsigned)
e5f6994 (unsigned)
b9cc5b6 (unsigned)
dcb06cd (unsigned)

Copy link

[puLL-Merge] - brave/brave-ads-docs@111

Description

This PR adds German, Spanish, French, and Portuguese translations for two new advertiser policy documents:

  1. Browser policies (browser-policies.md or browser policies.md)
  2. Search policies (search-policies.md or search policies.md)

The files contain comprehensive terms of service and policies for Brave advertising platforms including restrictions on CBD/THC/cryptocurrency advertising, legal frameworks, arbitration clauses, and technical requirements. Additionally, there's a small update to the German API documentation changing the capitalization of "Retrieves" from German to English.

Possible Issues

  • File naming inconsistency: Some files use spaces in filenames (browser policies.md) while others use hyphens (browser-policies.md), which could cause routing/linking issues in Docusaurus
  • Mixed language content: Several files contain significant English sections within translated documents, particularly in legal sections (disclaimers, liability limitations)
  • Large file sizes: These are substantial documents (190+ lines each) which could impact page load times
  • Duplicate content: The same policy content is duplicated across multiple languages, creating maintenance overhead

Security Hotspots

  • Legal compliance gaps: Mixed language content in legal documents could create enforceability issues or regulatory compliance problems in different jurisdictions
  • Arbitration clause exposure: The mandatory arbitration clauses contain jurisdiction-specific requirements that may not be legally valid in all target markets
  • Data processing disclosures: References to data collection and processing may need to comply with GDPR, CCPA and other regional privacy regulations beyond what's currently documented
Changes

Changes

  • docs/advertiser-policies/: Added two new empty placeholder files for browser and search policies
  • German translations (i18n/de/): Added complete German translations of both policy documents, plus minor API documentation update
  • Spanish translations (i18n/es/): Added complete Spanish translations of both policy documents
  • French translations (i18n/fr/): Added complete French translations of both policy documents
  • Portuguese translations (i18n/pt/): Added complete Portuguese translations of both policy documents
sequenceDiagram
    participant Dev as Developer
    participant Repo as brave-ads-docs
    participant Docs as Documentation Site
    participant User as End User
    
    Dev->>Repo: Add policy templates (EN)
    Dev->>Repo: Add German translations
    Dev->>Repo: Add Spanish translations  
    Dev->>Repo: Add French translations
    Dev->>Repo: Add Portuguese translations
    Repo->>Docs: Deploy multilingual policies
    User->>Docs: Access localized policies
    Docs->>User: Serve appropriate language version
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants