Skip to content

feat(out_of_lane): add objects.extra_width parameter #10923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Jul 4, 2025

Description

Add a parameter to make the dynamic object footprints wider, making it more likely to detect out_of_lane collisions.
Required launch PR: autowarefoundation/autoware_launch#1537

Related links

Private Links:

How was this PR tested?

Psim
Rosbags

Notes for reviewers

None.

Interface changes

None.

ROS Parameter Changes

Additions and removals

Change type Parameter Name Type Default Value Description
Added objects.extra_width double 1.0 [m] extra width around detected objects, making it more likely to detect an out of lane collision

Effects on system behavior

Can tune the out_of_lane collision detection.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jul 4, 2025
Copy link

github-actions bot commented Jul 4, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 4, 2025
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 19.83%. Comparing base (0bab769) to head (38a97ad).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
..._out_of_lane_module/src/out_of_lane_collisions.cpp 0.00% 3 Missing ⚠️
...city_out_of_lane_module/src/out_of_lane_module.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10923      +/-   ##
==========================================
- Coverage   19.90%   19.83%   -0.07%     
==========================================
  Files        1435     1436       +1     
  Lines      104444   104792     +348     
  Branches    34417    34508      +91     
==========================================
  Hits        20785    20785              
- Misses      67246    67594     +348     
  Partials    16413    16413              
Flag Coverage Δ *Carryforward flag
daily 20.35% <ø> (+<0.01%) ⬆️ Carriedforward from 0bab769
daily-cuda 18.73% <ø> (+<0.01%) ⬆️ Carriedforward from 0bab769
differential 0.49% <0.00%> (?)
total-cuda 19.89% <ø> (+<0.01%) ⬆️ Carriedforward from 0bab769

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maxime-clem maxime-clem force-pushed the feat/out_of_lane-objects_extra_width branch from a01f8a1 to d0f48de Compare July 17, 2025 05:47
@maxime-clem maxime-clem force-pushed the feat/out_of_lane-objects_extra_width branch from d0f48de to 38a97ad Compare July 17, 2025 06:06
@maxime-clem maxime-clem merged commit fd54b24 into autowarefoundation:main Jul 17, 2025
44 of 45 checks passed
@github-project-automation github-project-automation bot moved this from To Triage to Done in Software Working Group Jul 17, 2025
@maxime-clem maxime-clem deleted the feat/out_of_lane-objects_extra_width branch July 17, 2025 07:03
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants