Skip to content

feat(autoware_tensorrt_plugins): implemented a tensorrt plugin for the argsort operation #10601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 22, 2025

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented May 12, 2025

Description

Implemented a tensorrt plugin for the argsort operation.
ONNX and TensorRT supports this operation via the TopK operation, but TensorRT does not support large inputs, so I am directly implementing this operation as argsort
This PR is needed for #10600

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

knzo25 and others added 2 commits May 12, 2025 11:24
@knzo25 knzo25 requested review from manato and amadeuszsz May 12, 2025 03:10
@knzo25 knzo25 self-assigned this May 12, 2025
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels May 12, 2025
Copy link

github-actions bot commented May 12, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@knzo25 knzo25 requested a review from ktro2828 as a code owner May 15, 2025 05:54
Copy link
Contributor

@amadeuszsz amadeuszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only "style" comments.
LGTM!

@knzo25 knzo25 requested a review from MasatoSaeki as a code owner May 19, 2025 06:00
@knzo25
Copy link
Contributor Author

knzo25 commented May 19, 2025

@amadeuszsz
Do you if anything may have happenes to spconv and cudart? It seems they are not found, but I do not see anything in autoware that may have removed them

@amadeuszsz
Copy link
Contributor

amadeuszsz commented May 19, 2025

@amadeuszsz Do you if anything may have happenes to spconv and cudart? It seems they are not found, but I do not see anything in autoware that may have removed them

@knzo25
#10529 (comment)
In other words, there is no universe-devel-cuda with spconv available yet.

We need to wait for deployment - this workflow success.

…oware.universe into feat/tensorrt_plugins_argsort
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 98 lines in your changes missing coverage. Please review.

Project coverage is 24.67%. Comparing base (7663e87) to head (f73af80).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...n/autoware_tensorrt_plugins/src/argsort_plugin.cpp 0.00% 73 Missing ⚠️
...toware_tensorrt_plugins/src/argsort_ops/argsort.cu 0.00% 10 Missing ⚠️
...re_tensorrt_plugins/src/argsort_plugin_creator.cpp 0.00% 8 Missing ⚠️
...toware/tensorrt_plugins/argsort_plugin_creator.hpp 0.00% 4 Missing ⚠️
...oware_tensorrt_plugins/src/plugin_registration.cpp 0.00% 2 Missing ⚠️
...clude/autoware/tensorrt_plugins/argsort_plugin.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10601      +/-   ##
==========================================
- Coverage   24.85%   24.67%   -0.18%     
==========================================
  Files        1351     1371      +20     
  Lines      105078   105802     +724     
  Branches    39603    39632      +29     
==========================================
- Hits        26121    26111      -10     
- Misses      76473    77207     +734     
  Partials     2484     2484              
Flag Coverage Δ *Carryforward flag
differential-cuda 0.00% <0.00%> (?)
total 24.88% <ø> (+0.02%) ⬆️ Carriedforward from e458a9a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

knzo25 added 3 commits May 22, 2025 10:44
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@knzo25 knzo25 merged commit 14b321b into autowarefoundation:main May 22, 2025
42 of 43 checks passed
@github-project-automation github-project-automation bot moved this from To Triage to Done in Software Working Group May 22, 2025
firemark pushed a commit to firemark/autoware_universe that referenced this pull request Jun 13, 2025
…e argsort operation (autowarefoundation#10601)

* feat: implemented a argsort plugin for tensorrt

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* fix: forgot to add the plugin to the initalizer list

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: cspell

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* fix: mistook the compute capabilities of edge devices

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: added tensorrt 10 or later as a requirement

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: replaced 0 by nullptr

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: removed unused headers

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: removed double slash

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: removed unused headers

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: ci/cd

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: ci/cd

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* fix: forgot the noescept in the definition

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: ci/cd

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

---------

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
mkquda pushed a commit to tier4/autoware_universe that referenced this pull request Jun 16, 2025
…e argsort operation (autowarefoundation#10601)

* feat: implemented a argsort plugin for tensorrt

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* fix: forgot to add the plugin to the initalizer list

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: cspell

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* fix: mistook the compute capabilities of edge devices

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: added tensorrt 10 or later as a requirement

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: replaced 0 by nullptr

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: removed unused headers

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: removed double slash

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: removed unused headers

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: ci/cd

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: ci/cd

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* fix: forgot the noescept in the definition

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: ci/cd

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

---------

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test type:documentation Creating or refining documentation. (auto-assigned)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants