-
Notifications
You must be signed in to change notification settings - Fork 758
feat(autoware_ptv3): implemented an inference node for ptv3 using tensorrt #10600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@amadeuszsz @scepter914
Can you please upload the models for t4dataset that I left? (If you can retrain for 76m - 10cm that would be awesome too 🙏 ) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10600 +/- ##
==========================================
- Coverage 15.89% 15.78% -0.11%
==========================================
Files 1347 1356 +9
Lines 100088 100746 +658
Branches 32887 32981 +94
==========================================
Hits 15907 15907
- Misses 71982 72640 +658
Partials 12199 12199
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@amadeuszsz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this great PR! Initial review addressed, but could you please share ONNX file as I was not able to deploy your .pth model? I would like to check the runtime and try to crash it, check the latency etc.
@amadeuszsz |
Sure, I understand. After checking the runtime I can go with fixes by myself, of course if you allow me to work on your PR 🙇🏻♂️ |
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@amadeuszsz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I addressed (or attempted do) all the comments. Sadly, CI/CD does not pass, though I do not know why.
Please, try to add any fixes if you have time 🙏
@knzo25
Thanks for addressing all the comments! I will approve this PR as soon as I can get the ONNX and confirm the runtime.
Description
This PR implements an inference node for Point Transformer V3 (PTv3).
On a 10cm grid in the range of -76m - 76m, the processing times are
Related links
Branch containing all the PRs needed for inference
Related PRs:
Parent Issue:
Required PRs before this one can be merged:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.