Skip to content

✨ Source Zendesk Support: migration to low-code #56354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Mar 25, 2025

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Mar 23, 2025

What

This is a stacked PR including all the part for https://github.com/airbytehq/airbyte-internal-issues/issues/11894:

How

See the stacked PRs for more information

Review guide

The changes have been reviewed in the stacked PRs

User Impact

This should speed up some of the streams as they would now run in the concurrent engine.

It also removes ignore_pagination.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

There are some streams where the state changes which means we can't revert.

Copy link

vercel bot commented Mar 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 1:09pm

@maxi297
Copy link
Contributor Author

maxi297 commented Mar 24, 2025

Last round of regression tests (all considering state):

EDIT: analysis
posts:

  • There is client side filtering that exclude the cursor value (see this). The new version of the connector includes them which is fine as if there could be more records with the same datetime on updated_at
  • The format changes from the record value like "2025-01-10T18:13:29Z" to %s as it is what we send to the API. I have confirmed that the target version supports both format.
  • The state cursor value changes from the most_recent_cursor_value to the upper boundary of the requested slice

user_identities:

  • Green in regression tests
  • The format changes from the record value like "2025-01-10T18:13:29Z" to %s as it is what we send to the API. I have confirmed that the target version supports both format.

tickets:

  • One more record in the target version which we assume was added during the sync or is the state value that was filtered on the client side for the control version
  • The format changes from the record value like "2025-01-10T18:13:29Z" to %s as it is what we send to the API. I have confirmed that the target version supports both format.

articles:

  • One more record in the target version which we assume was added during the sync or is the state value that was filtered on the client side for the control version
  • The format changes from the record value like "2025-01-10T18:13:29Z" to %s as it is what we send to the API. I have confirmed that the target version supports both format.

article_votes:

  • No testing candidates

ticket_metrics:

  • One more record in the target version which we assume was added during the sync or is the state value that was filtered on the client side for the control version
  • The state on the first sync goes from a int to a string (for example, {"_ab_updated_at": 1742826806} before and {"_ab_updated_at": "1742826806"} after)
  • The state on subsequent syncs goes as per-partition state

Based on this, it seems like we are ready for a release tomorrow where most streams will be considered as a breaking change given the state changes.

@maxi297
Copy link
Contributor Author

maxi297 commented Mar 24, 2025

/approve-regression-tests

Check job output.

✅ Approving regression tests

Copy link
Contributor

@aldogonzalez8 aldogonzalez8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED

@maxi297 maxi297 merged commit c35002a into master Mar 25, 2025
33 of 34 checks passed
@maxi297 maxi297 deleted the issue-11894/prepare-low-code-release branch March 25, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants