✨ Source Zendesk Support: migrate posts to low-code #55680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
maxi297
commented
Mar 10, 2025
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/manifest.yaml
Show resolved
Hide resolved
maxi297
commented
Mar 10, 2025
| .with_record(PostsRecordBuilder.posts_record().with_cursor(datetime_to_string(_START_DATE.add(days=1)))) | ||
| .build(), | ||
| ) | ||
|
|
||
| output = read_stream("posts", SyncMode.full_refresh, config) | ||
|
|
||
| assert output.most_recent_state.stream_state == AirbyteStateBlob({"updated_at": most_recent_cursor_value}) | ||
| assert output.most_recent_state.stream_state == AirbyteStateBlob({"updated_at": str(most_recent_cursor_value.int_timestamp)}) |
There was a problem hiding this comment.
This should be the only change in terms of behavior
octavia-squidington-iii
added
the
area/documentation
|
WIP:
|
maxi297
commented
Mar 11, 2025
| stop_condition: "{{ config.get('ignore_pagination', False) or not response['meta']['has_more'] }}" | ||
| record_selector: | ||
| $ref: "#/definitions/retriever/record_selector" | ||
| schema_normalization: None |
There was a problem hiding this comment.
This is required because schema is a bit loose: for example, instead of integer as id, it is number which cast fields as float
|
I was able to run this locally using our sandbox connection with the following result: Hence, I would assume we're green for regression tests |
brianjlai
approved these changes
Mar 12, 2025
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/manifest.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/manifest.yaml
Show resolved
Hide resolved
…into issue-11894/posts-migration-to-low-code
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Partially addresses https://github.com/airbytehq/airbyte-internal-issues/issues/11894
Following the addition of tests in #55676, we can now migration the posts stream to low-code. We still keep the Python implementation because it is used as a parent for other streams. Those streams will require a breaking change as they are not per partition although they have a parent stream.
How
Review guide
User Impact
None, the change is for devs to have easier maintenance
Can this PR be safely reverted and rolled back?
Note: This change can be reverted to #55676 as we have a made a forward compatible version as shown by test
test_given_input_state_with_low_code_format_when_read_then_set_state_value_to_most_recent_cursor_valuefrom this PR