✨ Source Zendesk Support: tickets to low-code #55711
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
|
Regression testing: https://github.com/airbytehq/airbyte/actions/runs/13812823369 EDIT: The tests timed out and I can't debug why... EDIT2: regression testing part 2 https://github.com/airbytehq/airbyte/actions/runs/13820445417 EDIT3: It also times out. I'll try to pin a specific connection that might be smaller EDIT4: I've run this locally with connection Without state With state EDIT5: The timeout also affected our sandbox account is kind of worrying. I'll try to find a way to scope the issue regarding that. I would like to do a dev version but I would need to revert the state manually (which might be fine so I might do that but I would need to do a release with just the |
…94/tickets-to-low-code
…94/tickets-to-low-code
| @@ -243,20 +243,6 @@ def test_check_start_time_param(): | |||
| assert output == expected | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize( | |||
There was a problem hiding this comment.
Some cleanup here but I didn't remove the import because we still have TicketMetrics which uses the Python implementation of Tickets. My guess is that this whole file will just be deleted soon anyway
|
The CI is red only because of code coverage. I'll confirm if this is still an issue once the stacked PRs are merged |
|
The timeout was probably caused by this issue. Locally, things work fine some I'm not too worried about it |
|
For reference, this issue was the proxy. I don't know why locally this doesn't fail but eh! Here is an example without the proxy: https://github.com/airbytehq/airbyte/actions/runs/13997346842/job/39195655493 |
This reverts commit 36fa475.
…94/tickets-to-low-code
What
Partially addresses https://github.com/airbytehq/airbyte-internal-issues/issues/11894
Migrating tickets to low-code.
How
Adding tests, implementing stream in the manifest.yaml and removing the code in the python code.
Review guide
User Impact
This change is mostly to ease maintenance for devs and there shouldn't be any change in behavior.
Can this PR be safely reverted and rolled back?
The state will change from
{"generated_timestamp": 1728174882}to{"generated_timestamp": "1728174882"}and this method does not support the state to be a string. We could do a forward compatible change before releasing the migration if needed.