Skip to content

Introduce manual mixed precision quantization #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stamalakhov opened this issue Feb 7, 2023 · 4 comments
Closed

Introduce manual mixed precision quantization #1491

stamalakhov opened this issue Feb 7, 2023 · 4 comments
Assignees

Comments

@stamalakhov
Copy link
Contributor

stamalakhov commented Feb 7, 2023

What?

Let's implement manual mixed precision feature via editing quantization json file similar to PartEditor.

Why?

Currently setting all values via .json is laborious, so it seems like setting them in GUI will be more convenient.

@stamalakhov stamalakhov self-assigned this Feb 7, 2023
@stamalakhov stamalakhov changed the title [CfgEditor] Introduce manual mixed precision quantization Introduce manual mixed precision quantization Feb 9, 2023
@stamalakhov
Copy link
Contributor Author

Please correct me if I'm wrong, but
IMHO
the best way to create/edit .json suitable for mixed precision quantization is to create context_menu_item (e.g. create mixed precision quantization json) for float circle model or (edit mixed precision quantization json) for json file.

@seanshpark
Copy link
Contributor

seanshpark commented Feb 9, 2023

the best way to create/edit .json suitable for mixed precision ...

As I didn't think much on this feature but I can assume you had more on this.
Please share your idea with writing some draft so that others including me can try and think :)

One thing is that one GUI can be nice but can harm harmony with others.

Add: once we have the feature, we can later adjust the entry interface.

@stamalakhov
Copy link
Contributor Author

the best way to create/edit .json suitable for mixed precision ...

As I didn't think much on this feature but I can assume you had more on this. Please share your idea with writing some draft so that others including me can try and think :)

One thing is that one GUI can be nice but can harm harmony with others.

Add: once we have the feature, we can later adjust the entry interface.

Ok. Thank you. I'll be back with a draft.

@stamalakhov
Copy link
Contributor Author

All changes related to MPQ are merged, so it seems that we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants