Skip to content

[MPQEditor] Implement 'updateDocumentBy' #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stamalakhov
Copy link
Contributor

This commit implements 'updateDocumentBy' and adds tests for it.

Fresh draft: #1511
Previous draft: #1505
Related: #1491

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]

@stamalakhov stamalakhov requested a review from seanshpark April 7, 2023 05:52
@stamalakhov stamalakhov self-assigned this Apr 7, 2023
"default_granularity": "layer",
"layers": [],
"model_path": "sample_1.circle"
}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation seems incorrect

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanshpark
seems like i fixed it.

@stamalakhov stamalakhov force-pushed the manual_MPQ_updateDocumentBy_br branch from d78670d to ce0eaf8 Compare April 7, 2023 08:14
This commit implements 'updateDocumentBy' and adds tests for it.

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
@stamalakhov stamalakhov force-pushed the manual_MPQ_updateDocumentBy_br branch from ce0eaf8 to 55a0fe3 Compare April 7, 2023 08:17
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit a0132fa into Samsung:main Apr 7, 2023
@stamalakhov stamalakhov deleted the manual_MPQ_updateDocumentBy_br branch April 7, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants