Skip to content

[MPQEditor] Implement open and other commands #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

stamalakhov
Copy link
Contributor

@stamalakhov stamalakhov commented Apr 25, 2023

This commit implements open and other commands for MPQSelectionPanel.

Its correctness is tested in #1530

Fresh draft: #1530
Full draft: #1505
Related: #1491

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]

@stamalakhov stamalakhov self-assigned this Apr 25, 2023
@seanshpark
Copy link
Contributor

It would be better to change "other" to include actual command

Implement open and other commands

@stamalakhov
Copy link
Contributor Author

It would be better to change "other" to include actual command

Implement open and other commands

ok. Thank you.

Implement open and other commands for MPQSelectionPanel.

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
@stamalakhov stamalakhov force-pushed the manual_MPQ_mesgs_br branch from 9d0f81c to 592ef97 Compare April 25, 2023 08:52
@stamalakhov stamalakhov changed the title [MPQEditor] Implement additional commands [MPQEditor] Implement open and other commands Apr 25, 2023
@stamalakhov
Copy link
Contributor Author

It would be better to change "other" to include actual command

Implement open and other commands

@seanshpark
done

Copy link
Contributor

@dayo09 dayo09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit a76df0f into Samsung:main Apr 26, 2023
@stamalakhov stamalakhov deleted the manual_MPQ_mesgs_br branch April 27, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants