Skip to content

[MPQEditor] Introduce 'media' for MPQEditor #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

stamalakhov
Copy link
Contributor

This commit introduces 'media' for MPQEditor.

Draft: #1505
Related: #1491
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]

@stamalakhov stamalakhov self-assigned this Mar 13, 2023
This commit introduces 'media'  for MPQEditor.

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
@dayo09
Copy link
Contributor

dayo09 commented Mar 14, 2023

Thanks for your work! 😄

Inked62e0e08f-a495-4a0c-85a4-fc13f9382fa4
BTW, when I click on that 'X' icon in 'visq path' box, it only reloads the model.circle file on the right side. What does it mean to be?

@stamalakhov
Copy link
Contributor Author

Thanks for your work! smile

Inked62e0e08f-a495-4a0c-85a4-fc13f9382fa4 BTW, when I click on that 'X' icon in 'visq path' box, it only reloads the model.circle file on the right side. What does it mean to be?

It clears visq_view.
By default, the model-view opens in selector mode, but in case visq data is loaded, model_view load the model in visq mode. So to reset to selector mode, we may press the x button. But IMHO in case we don't visq data, it should be disabled.

@dayo09
Copy link
Contributor

dayo09 commented Mar 14, 2023

@stamalakhov

But IMHO in case we don't visq data, it should be disabled.

Oh, It seems that you just have removed the code.
So it's now unrelated but to say, but for later, I would like to suggest 'Show Graph' or 'Display Graph' instead of 'Model Graph', for the text next to the checkbox.

@stamalakhov
Copy link
Contributor Author

@stamalakhov

But IMHO in case we don't visq data, it should be disabled.

Oh, It seems that you just have removed the code. So it's now unrelated but to say, but for later, I would like to suggest 'Show Graph' or 'Display Graph' instead of 'Model Graph', for the text next to the checkbox.

Ahhh. OK. I'll rename it.

Copy link
Contributor

@dayo09 dayo09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 6e20240 into Samsung:main Mar 14, 2023
@stamalakhov stamalakhov deleted the manual_MPQ_media branch March 15, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants