Skip to content

[MPQEditor] Implement 'createDefaultMPQ' #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stamalakhov
Copy link
Contributor

This commit implements 'createDefaultMPQ' and adds tests for it.

Fresh draft: #1511
Previous draft: #1505
Related: #1491

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov [email protected]

This commit implements 'createDefaultMPQ' and adds tests for it.

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <[email protected]>
@stamalakhov stamalakhov requested a review from seanshpark April 6, 2023 12:21
@stamalakhov stamalakhov self-assigned this Apr 6, 2023
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 0ed653a into Samsung:main Apr 6, 2023
@stamalakhov stamalakhov deleted the manual_MPQ_createDefaultMPQ_br branch April 7, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants