fix: Fix send max on gas value changes #30523

OGPoyraz · 2025-02-24T08:37:37Z

Description

This PR aims to fix send max feature gas issues.

It also adds e2e tests that cover:

correct amount
gas modal changes (on picking 'low', 'medium', 'high'
adjusting manual values on gas modal
reacting gas estimation changes in network level

Related issues

Fixes: #30269

Manual testing steps

Usual send flow should work properly

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-02-24T09:11:57Z

Builds ready [23f4e0e]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1737 ± 107 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	387	2246	1660	367	176
		domContentLoaded	1406	2172	1714	217	104
		load	1415	2192	1737	222	107
		domInteractive	24	57	34	9	4
		backgroundConnect	10	76	27	20	9
		firstReactRender	14	80	32	22	11
		getState	5	66	20	21	10
		initialActions	0	52	3	11	5
		loadScripts	1017	1624	1276	175	84
		setupStore	7	69	20	21	10
		uiStartup	1621	2535	1996	258	124

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 8 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-24T13:22:14Z

Builds ready [04fd067]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1578 ± 92 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1349	2088	1567	189	91
		domContentLoaded	1341	2007	1539	179	86
		load	1358	2096	1578	191	92
		domInteractive	18	107	46	25	12
		backgroundConnect	10	92	42	28	13
		firstReactRender	13	80	40	25	12
		getState	4	57	13	15	7
		initialActions	0	1	0	0	0
		loadScripts	956	1432	1131	140	67
		setupStore	7	69	17	20	10
		uiStartup	1587	2254	1797	195	94

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 748 Bytes (0.01%)
common: 0 Bytes (0.00%)

ui/pages/confirmations/components/confirm/info/hooks/useMaxValueRefresher.ts

sleepytanya · 2025-02-24T16:34:20Z

Fix looks great @OGPoyraz

Sending Max on Sepolia:

sepolia.mov

Sending Eth Max on mainnet:

eth_mainnet.mov

Sending USDC Max on Polygon:

polygon_usdc.mov

Sending Eth Max using Advanced gas settings:

eth_adv_set.mov

metamaskbot · 2025-02-25T12:07:15Z

Builds ready [75fd32a]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1681 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1406	1903	1680	132	63
		domContentLoaded	1399	1888	1649	121	58
		load	1407	1903	1681	132	63
		domInteractive	19	117	40	25	12
		backgroundConnect	9	81	38	23	11
		firstReactRender	14	80	37	25	12
		getState	5	50	9	10	5
		initialActions	0	1	0	0	0
		loadScripts	975	1452	1211	116	56
		setupStore	7	55	13	13	6
		uiStartup	1619	2172	1913	131	63

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 748 Bytes (0.01%)
common: 86 Bytes (0.00%)

metamaskbot · 2025-02-26T07:42:14Z

Builds ready [91c14f9]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1758 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	359	2074	1684	346	166
		domContentLoaded	1408	2030	1721	165	79
		load	1464	2074	1758	162	78
		domInteractive	25	92	40	20	9
		backgroundConnect	15	87	42	18	9
		firstReactRender	14	73	30	21	10
		getState	5	65	21	21	10
		initialActions	0	1	0	0	0
		loadScripts	1014	1537	1282	140	67
		setupStore	7	53	14	12	6
		uiStartup	1695	2306	2005	178	85

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 878 Bytes (0.01%)
common: 86 Bytes (0.00%)

Fix send max

23f4e0e

metamaskbot added the team-confirmations Push issues to confirmations team label Feb 24, 2025

Updates

6b07156

OGPoyraz changed the title ~~temp: Fix send max~~ fix: Fix send max on gas value changes Feb 24, 2025

Update useMaxValueRefresher

04fd067

OGPoyraz marked this pull request as ready for review February 24, 2025 13:02

OGPoyraz requested a review from a team as a code owner February 24, 2025 13:02

pedronfigueiredo reviewed Feb 24, 2025

View reviewed changes

ui/pages/confirmations/components/confirm/info/hooks/useMaxValueRefresher.ts Show resolved Hide resolved

sleepytanya added the QA Passed label Feb 24, 2025

OGPoyraz added 6 commits February 25, 2025 10:23

Add missing e2e test

547bd3b

Remove log

0da8260

Remove log

eb815bf

Fix lint

01583c5

Fix tests

19ef5aa

Merge branch 'main' into ogp/fix-max-e2e

b6b2bd0

pedronfigueiredo previously approved these changes Feb 25, 2025

View reviewed changes

Fix lint issues

1f679f5

OGPoyraz dismissed pedronfigueiredo’s stale review via 1f679f5 February 25, 2025 10:33

OGPoyraz mentioned this pull request Feb 25, 2025

[Bug]: Sending all ETH with Max feature always gives error #30462

Closed

OGPoyraz linked an issue Feb 25, 2025 that may be closed by this pull request

[Bug]: Sending all ETH with Max feature always gives error #30462

Closed

Fix e2e

75fd32a

OGPoyraz requested a review from pedronfigueiredo February 25, 2025 12:17

pedronfigueiredo previously approved these changes Feb 25, 2025

View reviewed changes

Fix use max value tests

91c14f9

OGPoyraz dismissed pedronfigueiredo’s stale review via 91c14f9 February 26, 2025 07:05

OGPoyraz requested a review from pedronfigueiredo February 26, 2025 07:30

vinistevam approved these changes Feb 26, 2025

View reviewed changes

pedronfigueiredo approved these changes Feb 26, 2025

View reviewed changes

OGPoyraz added this pull request to the merge queue Feb 26, 2025

Merged via the queue into main with commit 4e2b1d4 Feb 26, 2025
79 checks passed

OGPoyraz deleted the ogp/fix-max-e2e branch February 26, 2025 10:32

github-actions bot locked and limited conversation to collaborators Feb 26, 2025

metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fix send max on gas value changes #30523

fix: Fix send max on gas value changes #30523

OGPoyraz commented Feb 24, 2025 •

edited

Loading

metamaskbot commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

sleepytanya commented Feb 24, 2025

metamaskbot commented Feb 25, 2025

metamaskbot commented Feb 26, 2025

fix: Fix send max on gas value changes #30523

fix: Fix send max on gas value changes #30523

Conversation

OGPoyraz commented Feb 24, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

metamaskbot commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

sleepytanya commented Feb 24, 2025

metamaskbot commented Feb 25, 2025

metamaskbot commented Feb 26, 2025

OGPoyraz commented Feb 24, 2025 •

edited

Loading