fix: Fix send max on gas value changes (#30523)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR aims to fix send max feature gas issues. 

It also adds e2e tests that cover: 
- correct amount
- gas modal changes (on picking 'low', 'medium', 'high'
- adjusting manual values on gas modal
- reacting gas estimation changes in network level

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30523?quickstart=1)

## **Related issues**

Fixes: #30269

## **Manual testing steps**

Usual send flow should work properly

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: OGPoyraz

test/e2e/page-objects/flows/transaction.ts

@@ -19,6 +19,22 @@ export const createInternalTransaction = async (driver: Driver) => {
   await sendToPage.goToNextScreen();
 };
 
+export const createInternalTransactionWithMaxAmount = async (
+  driver: Driver,
+) => {
+  // Firefox has incorrect balance if send flow started too quickly.
+  await driver.delay(1000);
+
+  const homePage = new HomePage(driver);
+  await homePage.startSendFlow();
+
+  const sendToPage = new SendTokenPage(driver);
+  await sendToPage.check_pageIsLoaded();
+  await sendToPage.fillRecipient('0x2f318C334780961FB129D2a6c30D0763d9a5C970');
+  await sendToPage.clickMaxAmountButton();
+  await sendToPage.goToNextScreen();
+};
+
 export const createDappTransaction = async (
   driver: Driver,
   override?: Partial<TransactionParams>,

test/e2e/page-objects/pages/send/send-token-page.ts

@@ -43,6 +43,8 @@ class SendTokenPage {
   private readonly warning =
     '[data-testid="send-warning"] .mm-box--min-width-0 span';
 
+  private readonly maxAmountButton = '[data-testid="max-clear-button"]';
+
   constructor(driver: Driver) {
     this.driver = driver;
   }
@@ -138,6 +140,10 @@ class SendTokenPage {
     await this.driver.pasteIntoField(this.inputRecipient, recipientAddress);
   }
 
+  async clickMaxAmountButton(): Promise<void> {
+    await this.driver.clickElement(this.maxAmountButton);
+  }
+
   async goToNextScreen(): Promise<void> {
     await this.driver.clickElement(this.continueButton);
   }