[Bug]: Send max not working on v12.11 although a fix was cherry picked to the RC #30269
Assignees
Labels
release-12.14.0
Issue or pull request that will be included in release 12.14.0
Sev2-normal
Normal severity; minor loss of service or inconvenience.
team-confirmations
Push issues to confirmations team
type-bug
Something isn't working
Comments
bschorchit
added
team-confirmations
metamaskbot
added
the
regression-prod-12.11.0
|
Present in v12.13.0: Chrome.movFirefox.mov |
|
Also confirming it is present in 12.13.0: max.mov |
sleepytanya
added
the
regression-RC-12.13.0
bschorchit
added
Sev2-normal
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 26, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix send max feature gas issues. It also adds e2e tests that cover: - correct amount - gas modal changes (on picking 'low', 'medium', 'high' - adjusting manual values on gas modal - reacting gas estimation changes in network level [](https://codespaces.new/MetaMask/metamask-extension/pull/30523?quickstart=1) ## **Related issues** Fixes: #30269 ## **Manual testing steps** Usual send flow should work properly ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-12.14.0
](https://codespaces.new/MetaMask/metamask-extension/pull/30523?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Original issue: #29903
Original fix PR: #29960
Cherry-pick PR: #29998
Slack thread
Goal of this issue: understand why the issue persisted on v12.11 after the cherry-pick and confirm that the issue is not present on v12.12
Expected behavior
No response
Screenshots/Recordings
No response
Steps to reproduce
Error messages or log output
Detection stage
In production (default)
Version
12.11.0
Build type
None
Browser
Brave
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: