Skip to content

Commit 23f4e0e

Browse files
committed
Fix send max
1 parent 2c72002 commit 23f4e0e

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

ui/pages/confirmations/components/confirm/info/hooks/useFeeCalculations.test.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ describe('useFeeCalculations', () => {
3333
"maxFeeFiat": "< $0.01",
3434
"maxFeeFiatWith18SignificantDigits": "0",
3535
"maxFeeNative": "0 ETH",
36-
"preciseNativeFeeInHex": "0x0",
36+
"preciseNativeMaxFeeInHex": "0x0",
3737
}
3838
`);
3939
});
@@ -62,7 +62,7 @@ describe('useFeeCalculations', () => {
6262
"maxFeeFiat": "$0.07",
6363
"maxFeeFiatWith18SignificantDigits": null,
6464
"maxFeeNative": "0.0001 ETH",
65-
"preciseNativeFeeInHex": "0x3be226d2d900",
65+
"preciseNativeMaxFeeInHex": "0x720087dcfc95",
6666
}
6767
`);
6868
});
@@ -94,7 +94,7 @@ describe('useFeeCalculations', () => {
9494
"maxFeeFiat": "$0.07",
9595
"maxFeeFiatWith18SignificantDigits": null,
9696
"maxFeeNative": "0.0001 ETH",
97-
"preciseNativeFeeInHex": "0x364ba3e2d900",
97+
"preciseNativeMaxFeeInHex": "0x720087dcfc95",
9898
}
9999
`);
100100
});
@@ -125,7 +125,7 @@ describe('useFeeCalculations', () => {
125125
"maxFeeFiat": "$0.07",
126126
"maxFeeFiatWith18SignificantDigits": null,
127127
"maxFeeNative": "0.0001 ETH",
128-
"preciseNativeFeeInHex": "0x103be226d2d900",
128+
"preciseNativeMaxFeeInHex": "0x720087dcfc95",
129129
}
130130
`);
131131
});

ui/pages/confirmations/components/confirm/info/hooks/useFeeCalculations.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ export function useFeeCalculations(transactionMeta: TransactionMeta) {
131131
currentCurrencyFeeWith18SignificantDigits:
132132
maxFeeFiatWith18SignificantDigits,
133133
nativeCurrencyFee: maxFeeNative,
134+
preciseNativeFeeInHex: preciseNativeMaxFeeInHex,
134135
} = getFeesFromHex(maxFee);
135136

136137
// Estimated fee
@@ -189,6 +190,6 @@ export function useFeeCalculations(transactionMeta: TransactionMeta) {
189190
maxFeeFiat,
190191
maxFeeFiatWith18SignificantDigits,
191192
maxFeeNative,
192-
preciseNativeFeeInHex: estimatedFees.preciseNativeFeeInHex,
193+
preciseNativeMaxFeeInHex: preciseNativeMaxFeeInHex,
193194
};
194195
}

ui/pages/confirmations/components/confirm/info/hooks/useMaxValueRefresher.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,15 @@ describe('useMaxValueRefresher', () => {
4040

4141
it('updates transaction value in max amount mode for simpleSend', () => {
4242
const balance = '0x111';
43-
const preciseNativeFeeInHex = '0x001';
43+
const preciseNativeMaxFeeInHex = '0x001';
4444
const newValue = '0x110';
4545

4646
(useSelector as jest.Mock)
4747
.mockReturnValueOnce(balance)
4848
.mockReturnValueOnce(true);
4949

5050
(useFeeCalculations as jest.Mock).mockReturnValue({
51-
preciseNativeFeeInHex,
51+
preciseNativeMaxFeeInHex,
5252
});
5353

5454
renderHook(() => useMaxValueRefresher());

ui/pages/confirmations/components/confirm/info/hooks/useMaxValueRefresher.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export const useMaxValueRefresher = () => {
2222
const { currentConfirmation: transactionMeta } =
2323
useConfirmContext<TransactionMeta>();
2424
const dispatch = useDispatch();
25-
const { preciseNativeFeeInHex } = useFeeCalculations(transactionMeta);
25+
const { preciseNativeMaxFeeInHex } = useFeeCalculations(transactionMeta);
2626
const balance = useSelector(getSelectedAccountCachedBalance);
2727
const isMaxAmountMode = useSelector((state) =>
2828
selectMaxValueModeForTransaction(state, transactionMeta?.id),
@@ -36,11 +36,11 @@ export const useMaxValueRefresher = () => {
3636
return;
3737
}
3838

39-
const newValue = subtractHexes(balance, preciseNativeFeeInHex);
39+
const newValue = subtractHexes(balance, preciseNativeMaxFeeInHex);
4040
const newValueInHex = add0x(newValue);
4141

4242
dispatch(
4343
updateEditableParams(transactionMeta.id, { value: newValueInHex }),
4444
);
45-
}, [isMaxAmountMode, balance, preciseNativeFeeInHex]);
45+
}, [isMaxAmountMode, balance, preciseNativeMaxFeeInHex]);
4646
};

0 commit comments

Comments
 (0)