[Tech] Add ts-prune to find dead code #2210

Nocccer · 2022-12-16T15:23:04Z

This PR adds ts-prune to find dead code or useless exports.

All dead code reported by ts-prune were removed
Adapt tests to still test the old now not anymore exported functions
Moved function notify to dialog. I didn't find a way to mock it from utils while testing utils functions. Utils is a large file and making it smaller makes sense anyway

Use the following Checklist if you have changed something on the Backend or Frontend:

Tested the feature and it's working on a current and clean install.
Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
Created / Updated Tests (If necessary)
Created / Updated documentation (If necessary)

* Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Translated using Weblate (French) Currently translated at 100.0% (401 of 401 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: John Donne <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/fr/ Translation: Heroic Games Launcher/GamePage Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Heroic Games Launcher/Globals Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ Co-authored-by: John Donne <[email protected]>

* fix: hide wine options on macOS * fix: playing status not changing correctly * fix: download progress color * fix: wine-manager reload button * fix: launch win sideloaded games on macOS * fix: isGameAvailable for sideloaded games * fix: dont show wine tools on windows and mac * feat: game not available status * feat: improved not available check on game page * i18n: updated keys * fix: dont show update button when not available * fix: gamecard not available classes * fix: getInstallInfo error when json parse fails * other: fade in card animation * chore: heroic version hover * fix: reload gamecard on status changes * fix: proper pass platform when importing epic games * i18n: updated keys * fix: compute saves path for windows games on macOS * fix: gamecard status not updating after import * feat: proper show not supported games * fix: codecheck * fix: Hiding a game doesn't remove it from the list unless re-rendered #2078 * fix: showing as not available after uninstall * fix: typo * fix: hide runexe for native games on sideload * fix: hide wine options for native games * fix: show refreshing icon when refreshing library * fix: pr comments * chore: renamed import * fix: remove install info for unsuported games * fix: dont fetch changelog if already saw it * fix: installing native macOS games for GOG * chore: removed audioFix settings and component

* other: updated tray icons and added OS logic * chore: log

* Translated using Weblate (Swedish) Currently translated at 100.0% (402 of 402 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: dpanter <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/sv/ Translation: Heroic Games Launcher/GamePage Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Heroic Games Launcher/Globals Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ Co-authored-by: dpanter <[email protected]>

* [Feature] Add DXVK FPS Limit toggle Checkbox to enable/disable DXVK FPS and a text field to input enter FPS cap value * Run prettier * Fix function not used error * Show for macOS Crossover and Linux Wine games * Add !nativeGame

src/backend/legendary/games.ts

src/backend/dialog/dialog.ts

src/backend/sideload/games.ts

.github/workflows/codecheck.yml

src/backend/online_monitor.ts

weblate and others added 14 commits November 28, 2022 19:09

[Revert] Revert #2075 (#2090)

42be510

chore: updated version

bf7a0d0

chore: readme update

db4e27b

fix: GameList Header columns

2f64232

fix: uninstalled status on game list

e9a05dd

fix: platform filter on macOS

1bfb1d8

chore: accurate macOS info

34d3fb7

fix: gog error message when apiData is null

e864e30

[Other] Update icons with better quality ones (#2096)

0f68949

* other: updated tray icons and added OS logic * chore: log

[Feature/Wine] Add DXVK Framerate Limit Toggle (#2068)

b97ec93

* [Feature] Add DXVK FPS Limit toggle Checkbox to enable/disable DXVK FPS and a text field to input enter FPS cap value * Run prettier * Fix function not used error * Show for macOS Crossover and Linux Wine games * Add !nativeGame

Add ts-prune

97537a9

Nocccer requested review from a team, arielj, flavioislima, CommandMC, imLinguin and redromnon and removed request for a team December 16, 2022 15:23

yarn i18n

c37bb32

Nocccer changed the base branch from beta to main December 17, 2022 12:17

Nocccer added 2 commits December 17, 2022 13:49

Merge branch 'main' into tech/add-ts-prune

d05a378

Merge clean up

2d0bf49

Nocccer added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 17, 2022

Nocccer added 2 commits December 18, 2022 15:02

Remove clearFinished

180ca42

Merge branch 'main' into tech/add-ts-prune

5d54888

flavioislima added the pr:conflicted PR conflicted, needs attention. label Dec 20, 2022

Merge branch 'main' into tech/add-ts-prune

44fc488

Nocccer removed the pr:conflicted PR conflicted, needs attention. label Jan 2, 2023

arielj reviewed Jan 3, 2023

View reviewed changes

src/backend/legendary/games.ts Outdated Show resolved Hide resolved

arielj reviewed Jan 3, 2023

View reviewed changes

src/backend/dialog/dialog.ts Outdated Show resolved Hide resolved

arielj reviewed Jan 3, 2023

View reviewed changes

src/backend/sideload/games.ts Show resolved Hide resolved

Nocccer added 2 commits January 6, 2023 18:32

Merge branch 'main' into tech/add-ts-prune

207f42a

Review suggestions

58a5c67

Nocccer requested a review from arielj January 6, 2023 17:37

Nocccer added 10 commits January 13, 2023 01:12

Merge branch 'main' into tech/add-ts-prune

fc0f34b

Merge branch 'main' into tech/add-ts-prune

19e0ba3

Only uncomment moveInstall

15d9bae

Debug workflow

9be9158

Remove debug

76f5de6

Debug workflow

b907831

Remove debug

76c7c38

Merge branch 'main' into tech/add-ts-prune

461ecc7

Dont export ProtonVerb

9cf7078

prettier-fix

e8cd9fa

Nocccer mentioned this pull request Jan 14, 2023

[Tech] Util restructure #2342

Closed

4 tasks

Merge branch 'main' into tech/add-ts-prune

5be5c4d

CommandMC approved these changes Jan 18, 2023

View reviewed changes

.github/workflows/codecheck.yml Outdated Show resolved Hide resolved

Nocccer added 4 commits January 18, 2023 18:59

Remove moveInstall for sideload apps

4599cf6

Merge branch 'main' into tech/add-ts-prune

b6d5f9f

Add find-deadcode to linter workflow

1a7d720

Merge branch 'main' into tech/add-ts-prune

c5aa961

flavioislima reviewed Jan 22, 2023

View reviewed changes

src/backend/online_monitor.ts Outdated Show resolved Hide resolved

Nocccer added 2 commits January 22, 2023 19:25

review fixes

0fdcadf

Merge branch 'main' into tech/add-ts-prune

d529c47

Nocccer requested a review from flavioislima January 22, 2023 18:35

flavioislima merged commit a5db684 into main Jan 23, 2023

flavioislima deleted the tech/add-ts-prune branch January 23, 2023 09:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[Tech] Add ts-prune to find dead code #2210

[Tech] Add ts-prune to find dead code #2210

Uh oh!

Nocccer commented Dec 16, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[Tech] Add ts-prune to find dead code #2210

[Tech] Add ts-prune to find dead code #2210

Uh oh!

Conversation

Nocccer commented Dec 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nocccer commented Dec 16, 2022 •

edited

Loading