[Fix] Beta 3 Fixes + some small improvements #2079

flavioislima · 2022-11-27T16:10:27Z

A few QOL improvements

Heroic will list Origin games but will show a warning and the install button will be disabled:

Not available games will have a different effect on the game card and a warning message on both GameCard and GamePage. Clicking on play will ask if the user wants to uninstall it:

Fixes

[macOS] Fix: Launching a windows sideloaded game
[macOS] Fix: proper get save path for windows games
[macOS] Fix: native GOG games failing to install
[Linux] Wine manager should show a Refresh button when the list is empty
Fix Sideloaded GameCards showing the install button instead of Play
Fix the game card status not changing after importing the game
Fix some settings appearing on the wrong platform
Fix the platform not being passed when importing Epic Games
Fix the Linear Progress color on the Downloads Manager
Fix hiding a game not reloading the library

Other

Refactor Winetricks download to use Axios instead of CURL, since it is a plain text
Removed AudioFix setting

Use the following Checklist if you have changed something on the Backend or Frontend:

Tested the feature and it's working on a current and clean install.
Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
Created / Updated Tests (If necessary)
Created / Updated documentation (If necessary)

…uncher into fix/250b3

…2078

redromnon · 2022-11-28T02:22:12Z

Fix some settings appearing on the wrong platform

As already mentioned in Discord, the Sideload games feature still shows Wine options for Linux platform games.

redromnon · 2022-11-28T02:25:18Z

Also once a game is uninstalled, it shows "not available" which it shouldn't. Just uninstalled one now and I see this.

flavioislima · 2022-11-28T10:40:42Z

Fix some settings appearing on the wrong platform

As already mentioned in Discord, the Sideload games feature still shows Wine options for Linux platform games.

totally forgot about that, fixed now.

flavioislima · 2022-11-28T10:40:54Z

Also once a game is uninstalled, it shows "not available" which it shouldn't. Just uninstalled one now and I see this.

fixed

src/backend/games.ts

src/backend/legendary/library.ts

src/backend/tools.ts

src/frontend/screens/Settings/sections/GamesSettings/index.tsx

…uncher into fix/250b3

* [i18n] Updated Translations (#2076) * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Translated using Weblate (French) Currently translated at 100.0% (401 of 401 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: John Donne <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/fr/ Translation: Heroic Games Launcher/GamePage Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Heroic Games Launcher/Globals Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ Co-authored-by: John Donne <[email protected]> * [Fix] Beta 3 Fixes + some small improvements (#2079) * fix: hide wine options on macOS * fix: playing status not changing correctly * fix: download progress color * fix: wine-manager reload button * fix: launch win sideloaded games on macOS * fix: isGameAvailable for sideloaded games * fix: dont show wine tools on windows and mac * feat: game not available status * feat: improved not available check on game page * i18n: updated keys * fix: dont show update button when not available * fix: gamecard not available classes * fix: getInstallInfo error when json parse fails * other: fade in card animation * chore: heroic version hover * fix: reload gamecard on status changes * fix: proper pass platform when importing epic games * i18n: updated keys * fix: compute saves path for windows games on macOS * fix: gamecard status not updating after import * feat: proper show not supported games * fix: codecheck * fix: Hiding a game doesn't remove it from the list unless re-rendered #2078 * fix: showing as not available after uninstall * fix: typo * fix: hide runexe for native games on sideload * fix: hide wine options for native games * fix: show refreshing icon when refreshing library * fix: pr comments * chore: renamed import * fix: remove install info for unsuported games * fix: dont fetch changelog if already saw it * fix: installing native macOS games for GOG * chore: removed audioFix settings and component * [Revert] Revert #2075 (#2090) * chore: updated version * chore: readme update * fix: GameList Header columns * fix: uninstalled status on game list * fix: platform filter on macOS * chore: accurate macOS info * fix: gog error message when apiData is null * [Other] Update icons with better quality ones (#2096) * other: updated tray icons and added OS logic * chore: log * [i18n] Updated Translations (#2088) * Translated using Weblate (Swedish) Currently translated at 100.0% (402 of 402 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: dpanter <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/sv/ Translation: Heroic Games Launcher/GamePage Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Heroic Games Launcher/Globals Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ Co-authored-by: dpanter <[email protected]> Co-authored-by: Weblate (bot) <[email protected]> Co-authored-by: John Donne <[email protected]> Co-authored-by: dpanter <[email protected]>

* [i18n] Updated Translations (#2076) * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Translated using Weblate (French) Currently translated at 100.0% (401 of 401 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: John Donne <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/fr/ Translation: Heroic Games Launcher/GamePage Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Heroic Games Launcher/Globals Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ Co-authored-by: John Donne <[email protected]> * [Fix] Beta 3 Fixes + some small improvements (#2079) * fix: hide wine options on macOS * fix: playing status not changing correctly * fix: download progress color * fix: wine-manager reload button * fix: launch win sideloaded games on macOS * fix: isGameAvailable for sideloaded games * fix: dont show wine tools on windows and mac * feat: game not available status * feat: improved not available check on game page * i18n: updated keys * fix: dont show update button when not available * fix: gamecard not available classes * fix: getInstallInfo error when json parse fails * other: fade in card animation * chore: heroic version hover * fix: reload gamecard on status changes * fix: proper pass platform when importing epic games * i18n: updated keys * fix: compute saves path for windows games on macOS * fix: gamecard status not updating after import * feat: proper show not supported games * fix: codecheck * fix: Hiding a game doesn't remove it from the list unless re-rendered #2078 * fix: showing as not available after uninstall * fix: typo * fix: hide runexe for native games on sideload * fix: hide wine options for native games * fix: show refreshing icon when refreshing library * fix: pr comments * chore: renamed import * fix: remove install info for unsuported games * fix: dont fetch changelog if already saw it * fix: installing native macOS games for GOG * chore: removed audioFix settings and component * [Revert] Revert #2075 (#2090) * chore: updated version * chore: readme update * fix: GameList Header columns * fix: uninstalled status on game list * fix: platform filter on macOS * chore: accurate macOS info * fix: gog error message when apiData is null * [Other] Update icons with better quality ones (#2096) * other: updated tray icons and added OS logic * chore: log * [i18n] Updated Translations (#2088) * Translated using Weblate (Swedish) Currently translated at 100.0% (402 of 402 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: dpanter <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/sv/ Translation: Heroic Games Launcher/GamePage Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Heroic Games Launcher/Globals Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ Co-authored-by: dpanter <[email protected]> * [Feature/Wine] Add DXVK Framerate Limit Toggle (#2068) * [Feature] Add DXVK FPS Limit toggle Checkbox to enable/disable DXVK FPS and a text field to input enter FPS cap value * Run prettier * Fix function not used error * Show for macOS Crossover and Linux Wine games * Add !nativeGame * Add ts-prune * yarn i18n * Merge clean up * Remove clearFinished * Merge fixes * yarn i18n * Review suggestions * Only uncomment moveInstall * Debug workflow * Remove debug * Debug workflow * Remove debug * Dont export ProtonVerb * prettier-fix * Remove moveInstall for sideload apps * Add find-deadcode to linter workflow * review fixes Co-authored-by: Weblate (bot) <[email protected]> Co-authored-by: John Donne <[email protected]> Co-authored-by: Flávio F Lima <[email protected]> Co-authored-by: dpanter <[email protected]> Co-authored-by: Rishabh Moharir <[email protected]>

flavioislima added 23 commits November 26, 2022 19:45

fix: hide wine options on macOS

d7b97c3

fix: playing status not changing correctly

14e7877

fix: download progress color

19d51b4

fix: wine-manager reload button

0d71106

fix: launch win sideloaded games on macOS

8bc61ee

fix: isGameAvailable for sideloaded games

f3d584e

fix: dont show wine tools on windows and mac

fa39cb0

feat: game not available status

0e8dbdb

feat: improved not available check on game page

c730607

i18n: updated keys

82c11a7

fix: dont show update button when not available

205168e

fix: gamecard not available classes

3276e26

fix: getInstallInfo error when json parse fails

8ab6394

Merge branch 'beta' of github.com:Heroic-Games-Launcher/HeroicGamesLa…

9aed7f6

…uncher into fix/250b3

other: fade in card animation

86b478b

chore: heroic version hover

303669d

fix: reload gamecard on status changes

37e891f

fix: proper pass platform when importing epic games

43aae3b

i18n: updated keys

9943e56

fix: compute saves path for windows games on macOS

ceca7f9

fix: gamecard status not updating after import

eebe0c8

feat: proper show not supported games

4358db2

fix: codecheck

fb2c92f

This was linked to issues Nov 27, 2022

[Beta 3] Current Found bugs #2061

Closed

Beta 3 Wine Manager issues #2066

Closed

Ea App installed but still showing download button in game library #2077

Closed

Origin(?) games are unavailable in the library #2067

Closed

flavioislima requested review from a team and arielj and removed request for a team November 27, 2022 16:22

flavioislima requested a review from redromnon November 27, 2022 16:22

flavioislima linked an issue Nov 27, 2022 that may be closed by this pull request

Hiding a game doesn't remove it from the list unless re-rendered #2078

Closed

fix: Hiding a game doesn't remove it from the list unless re-rendered #…

516c1bf

…2078

flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Nov 27, 2022

flavioislima added 4 commits November 28, 2022 10:49

fix: showing as not available after uninstall

4f1fdca

fix: typo

600a7cc

fix: hide runexe for native games on sideload

13cc004

fix: hide wine options for native games

84e1055

fix: show refreshing icon when refreshing library

553a442

CommandMC requested changes Nov 28, 2022

View reviewed changes

flavioislima added 2 commits November 28, 2022 12:02

fix: pr comments

be8b481

chore: renamed import

a102cf0

flavioislima requested a review from CommandMC November 28, 2022 11:06

CommandMC approved these changes Nov 28, 2022

View reviewed changes

flavioislima added 4 commits November 28, 2022 12:35

fix: remove install info for unsuported games

50fb61d

fix: dont fetch changelog if already saw it

1b6ddf5

fix: installing native macOS games for GOG

4cea3b2

chore: removed audioFix settings and component

699906a

flavioislima changed the base branch from beta to main November 28, 2022 18:08

flavioislima changed the base branch from main to beta November 28, 2022 18:09

Merge branch 'beta' of github.com:Heroic-Games-Launcher/HeroicGamesLa…

bf81f62

…uncher into fix/250b3

flavioislima merged commit 2af90df into beta Nov 28, 2022

flavioislima deleted the fix/250b3 branch November 28, 2022 18:15

CommandMC mentioned this pull request Nov 29, 2022

[Bug] Wine-related options appearing for Linux Native games #1998

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix] Beta 3 Fixes + some small improvements #2079

[Fix] Beta 3 Fixes + some small improvements #2079

flavioislima commented Nov 27, 2022 •

edited

Loading

redromnon commented Nov 28, 2022

redromnon commented Nov 28, 2022

flavioislima commented Nov 28, 2022

flavioislima commented Nov 28, 2022

[Fix] Beta 3 Fixes + some small improvements #2079

[Fix] Beta 3 Fixes + some small improvements #2079

Conversation

flavioislima commented Nov 27, 2022 • edited Loading

A few QOL improvements

Fixes

Other

redromnon commented Nov 28, 2022

redromnon commented Nov 28, 2022

flavioislima commented Nov 28, 2022

flavioislima commented Nov 28, 2022

flavioislima commented Nov 27, 2022 •

edited

Loading