[Feature] add virtual pagination in game list (library) #2075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavioislima
approved these changes
Nov 26, 2022
|
Thanks, I'm happy to help |
|
Reverting this one since it caused a bug where, when having both epic and GOG games, when using any type of filter was making items disappear until the library was reloaded. |
|
ok, it is not possible to revert it so I will need to manually remove the changes |
flavioislima
added a commit
that referenced
this pull request
Nov 28, 2022
flavioislima
added a commit
that referenced
this pull request
Nov 28, 2022
flavioislima
added a commit
that referenced
this pull request
Nov 29, 2022
* [i18n] Updated Translations (#2076) * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Translated using Weblate (French) Currently translated at 100.0% (401 of 401 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: John Donne <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/fr/ Translation: Heroic Games Launcher/GamePage Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Heroic Games Launcher/Globals Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ Co-authored-by: John Donne <[email protected]> * [Fix] Beta 3 Fixes + some small improvements (#2079) * fix: hide wine options on macOS * fix: playing status not changing correctly * fix: download progress color * fix: wine-manager reload button * fix: launch win sideloaded games on macOS * fix: isGameAvailable for sideloaded games * fix: dont show wine tools on windows and mac * feat: game not available status * feat: improved not available check on game page * i18n: updated keys * fix: dont show update button when not available * fix: gamecard not available classes * fix: getInstallInfo error when json parse fails * other: fade in card animation * chore: heroic version hover * fix: reload gamecard on status changes * fix: proper pass platform when importing epic games * i18n: updated keys * fix: compute saves path for windows games on macOS * fix: gamecard status not updating after import * feat: proper show not supported games * fix: codecheck * fix: Hiding a game doesn't remove it from the list unless re-rendered #2078 * fix: showing as not available after uninstall * fix: typo * fix: hide runexe for native games on sideload * fix: hide wine options for native games * fix: show refreshing icon when refreshing library * fix: pr comments * chore: renamed import * fix: remove install info for unsuported games * fix: dont fetch changelog if already saw it * fix: installing native macOS games for GOG * chore: removed audioFix settings and component * [Revert] Revert #2075 (#2090) * chore: updated version * chore: readme update * fix: GameList Header columns * fix: uninstalled status on game list * fix: platform filter on macOS * chore: accurate macOS info * fix: gog error message when apiData is null * [Other] Update icons with better quality ones (#2096) * other: updated tray icons and added OS logic * chore: log * [i18n] Updated Translations (#2088) * Translated using Weblate (Swedish) Currently translated at 100.0% (402 of 402 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: dpanter <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/sv/ Translation: Heroic Games Launcher/GamePage Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Heroic Games Launcher/Globals Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ Co-authored-by: dpanter <[email protected]> Co-authored-by: Weblate (bot) <[email protected]> Co-authored-by: John Donne <[email protected]> Co-authored-by: dpanter <[email protected]>
flavioislima
added a commit
that referenced
this pull request
Jan 23, 2023
* [i18n] Updated Translations (#2076) * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Translated using Weblate (French) Currently translated at 100.0% (401 of 401 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: John Donne <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/fr/ Translation: Heroic Games Launcher/GamePage Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Heroic Games Launcher/Globals Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ Co-authored-by: John Donne <[email protected]> * [Fix] Beta 3 Fixes + some small improvements (#2079) * fix: hide wine options on macOS * fix: playing status not changing correctly * fix: download progress color * fix: wine-manager reload button * fix: launch win sideloaded games on macOS * fix: isGameAvailable for sideloaded games * fix: dont show wine tools on windows and mac * feat: game not available status * feat: improved not available check on game page * i18n: updated keys * fix: dont show update button when not available * fix: gamecard not available classes * fix: getInstallInfo error when json parse fails * other: fade in card animation * chore: heroic version hover * fix: reload gamecard on status changes * fix: proper pass platform when importing epic games * i18n: updated keys * fix: compute saves path for windows games on macOS * fix: gamecard status not updating after import * feat: proper show not supported games * fix: codecheck * fix: Hiding a game doesn't remove it from the list unless re-rendered #2078 * fix: showing as not available after uninstall * fix: typo * fix: hide runexe for native games on sideload * fix: hide wine options for native games * fix: show refreshing icon when refreshing library * fix: pr comments * chore: renamed import * fix: remove install info for unsuported games * fix: dont fetch changelog if already saw it * fix: installing native macOS games for GOG * chore: removed audioFix settings and component * [Revert] Revert #2075 (#2090) * chore: updated version * chore: readme update * fix: GameList Header columns * fix: uninstalled status on game list * fix: platform filter on macOS * chore: accurate macOS info * fix: gog error message when apiData is null * [Other] Update icons with better quality ones (#2096) * other: updated tray icons and added OS logic * chore: log * [i18n] Updated Translations (#2088) * Translated using Weblate (Swedish) Currently translated at 100.0% (402 of 402 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: dpanter <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/sv/ Translation: Heroic Games Launcher/GamePage Translation: Heroic Games Launcher/Globals * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translation: Heroic Games Launcher/GamePage * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Heroic Games Launcher/Globals Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ Co-authored-by: dpanter <[email protected]> * [Feature/Wine] Add DXVK Framerate Limit Toggle (#2068) * [Feature] Add DXVK FPS Limit toggle Checkbox to enable/disable DXVK FPS and a text field to input enter FPS cap value * Run prettier * Fix function not used error * Show for macOS Crossover and Linux Wine games * Add !nativeGame * Add ts-prune * yarn i18n * Merge clean up * Remove clearFinished * Merge fixes * yarn i18n * Review suggestions * Only uncomment moveInstall * Debug workflow * Remove debug * Debug workflow * Remove debug * Dont export ProtonVerb * prettier-fix * Remove moveInstall for sideload apps * Add find-deadcode to linter workflow * review fixes Co-authored-by: Weblate (bot) <[email protected]> Co-authored-by: John Donne <[email protected]> Co-authored-by: Flávio F Lima <[email protected]> Co-authored-by: dpanter <[email protected]> Co-authored-by: Rishabh Moharir <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtual pagination included in game list, using infinite scroll, to smoothly render large lists. An improvement would be to send the paginated list directly from the backend and include it in the other lists
pagination-heroic-games.webm
P.S. This is my first contribution to this project, I hope it helps if you need it
Use the following Checklist if you have changed something on the Backend or Frontend: