-
Notifications
You must be signed in to change notification settings - Fork 30
refactor(verification): finish moving all verification methods [part 5/5] #800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9f2245e
to
422ec12
Compare
bfc8907
to
9145c97
Compare
422ec12
to
48feebd
Compare
9145c97
to
7093fa5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #800 +/- ##
==========================================
- Coverage 84.60% 84.57% -0.03%
==========================================
Files 269 270 +1
Lines 22278 22289 +11
Branches 3402 3405 +3
==========================================
+ Hits 18848 18852 +4
- Misses 2761 2766 +5
- Partials 669 671 +2
☔ View full report in Codecov by Sentry. |
48feebd
to
2bc5ebd
Compare
ca40831
to
db9591a
Compare
2bc5ebd
to
4af2cfb
Compare
db9591a
to
d6caa5c
Compare
4af2cfb
to
7407fc6
Compare
d6caa5c
to
e62cc24
Compare
7407fc6
to
c5ae653
Compare
e62cc24
to
07ff57b
Compare
c5ae653
to
78890ea
Compare
07ff57b
to
363be05
Compare
78890ea
to
389903c
Compare
432abb0
to
2ca6cb6
Compare
bc5f263
to
dc17bcb
Compare
The base branch was changed.
dc17bcb
to
f5f7fe7
Compare
f5f7fe7
to
bc6f21d
Compare
bc6f21d
to
0a78bb9
Compare
Depends on #799
Motivation
This is the last PR in a 5-part series of PRs that completely move verification-related code out of the vertex model classes.
This PR moves the verification method implementations of
BaseTransaction
, finishing the code migration. This also allows us to remove theverify_pow()
simulator patch, as it can now be customized via injected verifiers.Acceptance Criteria
BaseTransaction
verification methods from the original model classes, moving the implementation to theVertexVerifier
class.verify_outputs()
implementation.Simulator
verifiers such thatverify_pow()
is overridden.Simulator
to use the custom verifiers, removing theverify_pow()
patch.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged