refactor(verification): move verification methods #786
+918
−693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
refactor/verification-service
branch
from
1121a3c to
fe3c2e9
Compare
glevco
force-pushed
the
refactor/move-verification-methods
branch
from
8c1888f to
d8e40db
Compare
glevco
changed the base branch from
refactor/verification-service
to
refactor/hathor-manager-settings
glevco
changed the title
1 task
glevco
force-pushed
the
refactor/hathor-manager-settings
branch
from
7782a41 to
0e19938
Compare
glevco
force-pushed
the
refactor/move-verification-methods
branch
from
d8e40db to
c36589e
Compare
glevco
force-pushed
the
refactor/hathor-manager-settings
branch
from
0e19938 to
3c084df
Compare
glevco
force-pushed
the
refactor/move-verification-methods
branch
from
c36589e to
0bf3cfd
Compare
glevco
force-pushed
the
refactor/hathor-manager-settings
branch
2 times, most recently
from
748afab to
0a9b949
Compare
glevco
force-pushed
the
refactor/move-verification-methods
branch
from
0bf3cfd to
a5b0b94
Compare
glevco
force-pushed
the
refactor/move-verification-methods
branch
from
a5b0b94 to
da50f53
Compare
glevco
changed the base branch from
refactor/hathor-manager-settings
to
refactor/genesis
1 task
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor/genesis #786 +/- ##
===================================================
Coverage ? 84.75%
===================================================
Files ? 267
Lines ? 22134
Branches ? 3386
===================================================
Hits ? 18760
Misses ? 2715
Partials ? 659 ☔ View full report in Codecov by Sentry. |
|
Moved to a 5-part series of PRs, ending in #800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #794
Motivation
What was the motivation for the changes in this PR?
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged