-
Notifications
You must be signed in to change notification settings - Fork 29
feat(feature-activation): implement must signal #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d34ad69
to
f2e6a65
Compare
1121a3c
to
fe3c2e9
Compare
f2e6a65
to
a954e43
Compare
43c3ede
to
dd6cfa1
Compare
0bf3cfd
to
a5b0b94
Compare
706bb68
to
8cb11f7
Compare
a5b0b94
to
da50f53
Compare
8f1dd2f
to
607a83d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #785 +/- ##
==========================================
+ Coverage 84.61% 85.00% +0.38%
==========================================
Files 271 271
Lines 22311 22362 +51
Branches 3406 3416 +10
==========================================
+ Hits 18878 19008 +130
+ Misses 2764 2677 -87
- Partials 669 677 +8
☔ View full report in Codecov by Sentry. |
808620c
to
c0e2be9
Compare
c0e2be9
to
e61761d
Compare
d6caa5c
to
e62cc24
Compare
709bf10
to
ebd7ea9
Compare
e62cc24
to
07ff57b
Compare
ebd7ea9
to
afd4ade
Compare
07ff57b
to
363be05
Compare
afd4ade
to
d90d744
Compare
f5f7fe7
to
bc6f21d
Compare
6f3992c
to
01c52c0
Compare
bc6f21d
to
0a78bb9
Compare
Base automatically changed from
refactor/move-verification/vertex-methods
to
master
October 25, 2023 17:10
01c52c0
to
d4ee187
Compare
msbrogli
requested changes
Oct 25, 2023
msbrogli
requested changes
Oct 26, 2023
msbrogli
previously approved these changes
Oct 31, 2023
jansegre
approved these changes
Nov 1, 2023
msbrogli
approved these changes
Nov 1, 2023
c070320
to
b6294a8
Compare
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #800
Motivation
Implement the mandatory signaling mechanism required by the Feature Activation process.
Acceptance Criteria
Builder
:FeatureService
toBuildArtifacts
_get_or_create_*
methods so they can all be used without arguments._get_or_create_settings()
and_get_or_create_feature_service()
methods to public so they can be used externally (specifically, so theSimulator
can properly customize the builder).FeatureService.check_must_signal()
.FeatureService.get_state()
caused by must signal verification.Block.get_feature_activation_bit_counts()
, and changecalculate_feature_activation_bit_counts()
toget_feature_activation_bit_counts()
.Block.update_feature_state()
toset_feature_state()
.BaseTransaction._update_feature_activation_bit_counts_metadata()
as it's not necessary anymore.BlockVerifier.verify_mandatory_signaling()
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged