-
Notifications
You must be signed in to change notification settings - Fork 29
refactor(settings): change daa to use injected settings #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #801 +/- ##
==========================================
- Coverage 85.06% 85.02% -0.05%
==========================================
Files 275 271 -4
Lines 22502 22380 -122
Branches 3434 3419 -15
==========================================
- Hits 19142 19029 -113
- Misses 2674 2676 +2
+ Partials 686 675 -11
☔ View full report in Codecov by Sentry. |
9145c97
to
7093fa5
Compare
09ee92f
to
c76fb12
Compare
ca40831
to
db9591a
Compare
d6caa5c
to
e62cc24
Compare
bc6f21d
to
0a78bb9
Compare
d2f2993
to
22c4e78
Compare
22c4e78
to
2bcbc81
Compare
Depends on #800
Motivation
This PR changes the DAA module so it stops depending on global settings, allowing its simulator patch to be removed.
Acceptance Criteria
daa.MIN_BLOCK_WEIGHT
anddaa.AVG_TIME_BETWEEN_BLOCKS
global variables, moving them to the class instance.HathorManager
.VertexVerifiers
.Builder
andCliBuilder
accordingly.Simulator
to use injected DAA class, removing the DAA simulator patch.daa
module to use the DAA class.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged