Revert "Revert "Share extension Android and iOS implementation"" #58834

289Adam289 · 2025-03-20T18:08:50Z

This reverts commit e167cd9.

Explanation of Change

This PR reapplies changes from #55748

cc @grgia @shubham1206agra

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13484

Fixed Issues

$ #48788
$ #48789
PROPOSAL:

Tests

Share test:

Choose a file to share or select plain text. Supported extensions are:

images: jpg, jpeg ,gif ,png ,tif ,tiff
documents: pdf, docx, doc, rtf, zip, eml
text: txt, html, xml
audio: mp3, aac, flac, wav, wave, ogg, opus
video: mp4, ts, webm, mkv, av1

Select 'Expensify' as the target application to share to
Choose 'Share' tab
Choose a recipient/workspace to share to
Check if 'Share Details' page displays correctly, specifically attachment's section -
- no attachment if you shared text
- file's thumbnail if you shared image/video
- rectangle with file's name and paperclip icon in the rest of the cases
Check if clicking in image/video thumbnail opens full-size modal with image/video
Enter message
Select 'Share'
Check if shared content was shared successfully (added to chat with recipient or new chat was created)

Submit test:

Choose a file to share from gallery/file manager on device. Supported files are:

images: jpg, jpeg ,gif ,png ,tif ,tiff
documents: pdf, docx, doc, rtf, zip, eml
text: txt, html, xml

Select 'Expensify' as the target application to share to
Choose 'Submit' tab (should be available)
Choose a recipient/workspace to share to
Check if 'Submit Details' page displays correctly, specifically attachment's section with file's thumbnail
Add description and save it
Select 'Submit'
Check if shared content was submitted successfully (added to chat with recipient or new chat was created)

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as steps
// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

This reverts commit e167cd9.

github-actions · 2025-03-20T18:09:01Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-03-20T18:51:45Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

289Adam289 · 2025-03-20T19:25:56Z

@grgia There were conflicts in project.pbxproj when reverting the revert. I will check tomorrow whether everything works and I will open this PR. If everything goes according to plan we can test adhoc again tomorrow

grgia · 2025-03-21T15:14:13Z

ios/ShareViewController/Info.plist

+                <key>NSExtensionActivationSupportsFileWithMaxCount</key>
+                <integer>1</integer>
+                <key>NSExtensionActivationSupportsText</key>
+                <true/>


documenting - https://github.com/Expensify/App/pull/58761/files

grgia · 2025-03-21T16:20:25Z

@289Adam289 ping me when you're ready to build. I added @luacmartins as a reviewer as well to keep track of this one

github-actions · 2025-03-24T10:07:09Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-03-24T10:21:20Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

melvin-bot · 2025-03-24T10:25:21Z

@ikevin127 @grgia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

289Adam289 · 2025-03-24T10:27:20Z

@grgia I think we are ready to build. I hope everything works

github-actions · 2025-03-24T14:19:50Z

🚧 @grgia has triggered a test app build. You can view the workflow run here.

grgia · 2025-03-24T15:17:12Z

cc @shubham1206agra are you able to do the final checklist for this build so it's ready for the next deploy today?

github-actions · 2025-03-24T16:18:53Z

🚧 @grgia has triggered a test app build. You can view the workflow run here.

grgia · 2025-03-24T16:53:07Z

^ reran android due to 1Pass 500 error

github-actions · 2025-03-24T17:23:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/58834-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/58834-hybrid/index.html

Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
N/A	N/A
N/A	N/A
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

shubham1206agra · 2025-03-24T17:43:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

github-actions · 2025-03-24T21:30:48Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.1.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	cancelled 🔪
🍎🔄 iOS HybridApp 🍎🔄	cancelled 🔪

github-actions · 2025-03-26T05:04:32Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.18-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Revert "Revert "Share extension Android and iOS implementation""

8ab431a

This reverts commit e167cd9.

289Adam289 added 2 commits March 20, 2025 19:48

Fix NSExtensionActivationSupportsText type

c7b7f74

Merge branch 'main' into 289Adam289/native-share-implementation

e267262

289Adam289 added 2 commits March 21, 2025 09:47

Merge branch 'main' into 289Adam289/native-share-implementation

f8fa69f

Merge branch 'main' into 289Adam289/native-share-implementation

18fbe5d

grgia self-requested a review March 21, 2025 15:13

grgia reviewed Mar 21, 2025

View reviewed changes

grgia requested review from shubham1206agra and luacmartins March 21, 2025 15:47

luacmartins changed the title ~~Revert "Revert "Share extension Android and iOS implementation""~~ [HOLD deploy] Revert "Revert "Share extension Android and iOS implementation"" Mar 21, 2025

fix project.pbxproj

8e580e8

Merge branch 'main' into 289Adam289/native-share-implementation

220b45a

289Adam289 marked this pull request as ready for review March 24, 2025 10:25

289Adam289 requested review from a team as code owners March 24, 2025 10:25

melvin-bot bot requested review from grgia and ikevin127 and removed request for a team March 24, 2025 10:25

This comment has been minimized.

Sign in to view

grgia approved these changes Mar 24, 2025

View reviewed changes

grgia added the Ready To Build label Mar 24, 2025

luacmartins approved these changes Mar 24, 2025

View reviewed changes

shubham1206agra approved these changes Mar 24, 2025

View reviewed changes

melvin-bot bot requested a review from grgia March 24, 2025 17:44

grgia approved these changes Mar 24, 2025

View reviewed changes

grgia changed the title ~~[HOLD deploy] Revert "Revert "Share extension Android and iOS implementation""~~ Revert "Revert "Share extension Android and iOS implementation"" Mar 24, 2025

grgia merged commit acc2e84 into Expensify:main Mar 24, 2025
25 of 27 checks passed

github-actions bot mentioned this pull request Mar 24, 2025

Deploy Checklist: New Expensify 2025-03-24 #59011

Closed

48 tasks

jponikarchuk mentioned this pull request Mar 25, 2025

[Native Share] Android - Share file - Share modal reopens after changing app location permission settings #59072

Open

8 tasks

Revert "Revert "Share extension Android and iOS implementation"" #58834

Revert "Revert "Share extension Android and iOS implementation"" #58834

Uh oh!

Conversation

289Adam289 commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

289Adam289 commented Mar 20, 2025

Uh oh!

grgia Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

grgia commented Mar 21, 2025

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

melvin-bot bot commented Mar 24, 2025

Uh oh!

289Adam289 commented Mar 24, 2025

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

This comment has been minimized.

grgia commented Mar 24, 2025

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

grgia commented Mar 24, 2025

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

shubham1206agra commented Mar 24, 2025

Reviewer Checklist

Uh oh!

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

github-actions bot commented Mar 26, 2025

Uh oh!

Uh oh!

289Adam289 commented Mar 20, 2025 •

edited

Loading