Skip to content

[Due for payment 2025-04-03] [Due for payment 2025-04-02] [Native Share] Android- Share file-App shows invalid file type modal when sharing valid mp4 file from gallery #59025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
mitarachim opened this issue Mar 25, 2025 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

mitarachim commented Mar 25, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.18-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #58834
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Other

Action Performed:

  1. Open a video from device gallery.
  2. Tap Share.
  3. Select Expensify.

Expected Result:

App will open share modal.

Actual Result:

App shows invalid file type modal when sharing valid mp4 file from gallery.
If user shares mp4 file directly in chat after sharing fails from gallery, it will also show the error modal. User will need to kill the app and relaunch the app in order to send mp4 file in chat without error.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6781017_1742859127112.1000044192.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @bfitzexpensify
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Mar 25, 2025
Copy link

melvin-bot bot commented Mar 25, 2025

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 25, 2025

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Mar 25, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 25, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@grgia
Copy link
Contributor

grgia commented Mar 25, 2025

Self assigning as this is native share related

@grgia
Copy link
Contributor

grgia commented Mar 25, 2025

@grgia
Copy link
Contributor

grgia commented Mar 25, 2025

Triaged as 🔴 as this blocks main flows

@Gonals Gonals removed the DeployBlocker Indicates it should block deploying the API label Mar 25, 2025
@Gonals
Copy link
Contributor

Gonals commented Mar 25, 2025

Not an API blocker

@grgia grgia changed the title Android- Share file-App shows invalid file type modal when sharing valid mp4 file from gallery [Native Share] Android- Share file-App shows invalid file type modal when sharing valid mp4 file from gallery Mar 25, 2025
@289Adam289
Copy link
Contributor

Hi, I am Adam from SWM I was working on Share Extension pr and I'd like to work on this issue.

@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Mar 26, 2025
@melvin-bot melvin-bot bot changed the title [Native Share] Android- Share file-App shows invalid file type modal when sharing valid mp4 file from gallery [Due for payment 2025-04-02] [Native Share] Android- Share file-App shows invalid file type modal when sharing valid mp4 file from gallery Mar 26, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 26, 2025
Copy link

melvin-bot bot commented Mar 26, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 26, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.18-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-02. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 26, 2025

@shubham1206agra @bfitzexpensify @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@cristipaval cristipaval removed the DeployBlockerCash This issue or pull request should block deployment label Mar 26, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Mar 27, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-04-02] [Native Share] Android- Share file-App shows invalid file type modal when sharing valid mp4 file from gallery [Due for payment 2025-04-03] [Due for payment 2025-04-02] [Native Share] Android- Share file-App shows invalid file type modal when sharing valid mp4 file from gallery Mar 27, 2025
Copy link

melvin-bot bot commented Mar 27, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-03. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 27, 2025

@shubham1206agra @bfitzexpensify @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@shubham1206agra
Copy link
Contributor

@bfitzexpensify No payment is required here. Please close the issue.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

8 participants