[Native Share] Android - Share file - Share modal reopens after changing app location permission settings

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.18-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #58834
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Other

Action Performed:

Precondition:

• App location access is "Allow only while using the app".
• App is killed.

1. Open an image in the device gallery app.
2. Tap Share.
3. Select Expensify app.
4. Tap app back button.
5. Go to app settings.
6. Open location permission settings.
7. Select Don't allow.
8. Go back to Expensify app.

Expected Result:

App will not reopen Share modal.

Actual Result:

App reopens Share modal after changing app location permission settings.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kadiealexander]

Android <> iOS bug swap

[grgia]

This doesnt feel like a bug to me, WDYT @shubham1206agra

[shubham1206agra]

@grgia It looks like a bug since we got out of the native share menu, and then it reappeared. But this should be a low priority as this is an edge case. Or it might be an Android issue.

[grgia]

@289Adam289

[289Adam289]

Hi, I can work on this.

[jliexpensify]

All yours @289Adam289

[melvin-bot]

@jliexpensify @grgia @shubham1206agra @289Adam289 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[jliexpensify]

How are we going here @289Adam289 ?

[289Adam289]

I've investigated this issue for a while but it appears to be more complicated than I anticipated especially that it is reproducible both on ND and Hybrid. This is a weekly so I moved my focus to more urgent tasks. I will investigate further in the coming days.

[grgia]

Thank you for the update @289Adam289

[grgia]

@289Adam289 did we fix this one, I don't see a PR linked to it

[289Adam289]

@grgia This one is not fixed. I didn't really have a chance to take this one. I've talked to @mateuuszzzzz and he will probably find some time next week work on this issue.

[grgia]

Thank you for the update @289Adam289

[mateuuszzzzz]

When we change permissions, Android restarts the activity. However, for some reason, it also sends the previously used intent again, which causes us to navigate back to the share screen. I'll be looking into potential solutions to fix this.

[mateuuszzzzz]

I suspect that the same issue might occur with other permissions and different types of intents, such as deeplinks. If this is confirmed, should we address all such issues?

[grgia]

I suspect that the same issue might occur with other permissions and different types of intents, such as deeplinks. If this is confirmed, should we address all such issues?

@mateuuszzzzz Do you have an update on this path? I'd be curious to hear if you think it's worth it.

[mateuuszzzzz]

I was trying to find any place in the codebase that could lead to this behaviour, but it really seems like Android is re-sending those intents, and we don’t have much control over it. Tricks like storing the previous intent and comparing it with the new one could break other things.

I think it might not be worth investing more time into this task since it's the intended behaviour.