-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-04-02] [Due for payment 2025-03-28] [Due for payment 2025-02-18] [Native Share] Implement Native Share for IOS #48788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey, I'm from SWM, I'd like to take care of this issue. |
Bumped for update / steps for unblocking permissions |
I am focusing on split navigation atm. I'll try to check the setup whenever it's applied and try to continue whenever the navigation is ready. |
Taking care of this atm. I've checked the groups before the weekend and they seemed to work as expected. |
Working on the files processing - they are being saved correctly from the share extenbsion, but there's something wrong with retrieving them on the react native side. This might be something related to the permissions, but I'll try to confirm it tomorrow. |
Thanks @BrtqKr- do you have a draft PR up for your branch? |
Not yet, wired it up though and the files are being passed to the react native wihthout any issues, so happily there's no need for the additional set-ups. I'll be verifying the scanning/sending with the passed files tomorrow, so this would probably be the initial version for the ios. I'll share more details next evening. |
Moving forward with that - wired up most of the js parts - I'll continue working on that and the files cleanup after sharing tomorrow |
Sounds great, thanks @BrtqKr |
Still working on the JS part - today it was mostly persistence and onyx-related things, which are necessary for removing files - it's not done yet though |
Continued the topic from yesterday. I've found some edge cases about the cleanup part - there's an issue when the share attempt gets cancelled and the file isn't removed properly, but we can handle this by performing cleanups for the files older than a week. Besides I had to slightly modify the model for the image, but apply small updates to the doc when I'm sure everything works. |
Great @BrtqKr, do you have an idea for when we might be able to get this into the review stage? |
@grgia, I've finished wiring up the core version for the ios today. Also, @filip-solecki mentioned that there wasn't much left regarding the Android native part, so I'd say that the remaining things before the PR would be:
The first three points shouldn't take much time since those are just the follow-ups to the already existing parts (the second point is a bit troublesome to test though). I'm not sure about the fourth point. As long as everything goes as expected on the hybrid part we should be able to send the final version sometime at the beginning the next week, but this is something @staszekscp or @war-in would need to estimate when they start applying the changes. Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-08.at.02.19.43.mp4 |
Hi! Quick update - I took the issue from @BrtqKr and I'll work on both right now as JS part will be shared for both Android and iOS |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.16-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-03-28. 🎊 For reference, here are some details about the assignees on this issue:
|
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.18-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-04-02. 🎊 For reference, here are some details about the assignees on this issue:
|
In regression period |
Payment Summary
BugZero Checklist (@sonialiap)
|
@grgia I see this got linked to a few deploy blockers, did this cause any regressions? |
@sonialiap no regressions! |
Thanks! |
Payment summary:
Since this is a new feature, most of the checklist is not relevant |
@sonialiap I think we forgot to handle the payout for @shubham1206agra's C+ review. Would you please help with $500 review payment for this PR? #58834 |
Thanks for reopening! Payment summary:
|
$500 approved for @shubham1206agra |
Uh oh!
There was an error while loading. Please reload this page.
Description
This is a tracking issue for the IOS implementation of the Native Share project. This section of the project will be handled separately but merged alongside the Android issue.
Project
https://docs.google.com/document/d/14C1VifxvIXeyLAf0XstbC-wvyAb5SQZ0AOw0-jLRyZs/edit
Tracking
#36613
Issue Owner
Current Issue Owner: @sonialiapThe text was updated successfully, but these errors were encountered: