Skip to content

[Due for payment 2025-04-02] [Due for payment 2025-03-28] [Due for payment 2025-02-18] [Native Share] Implement Native Share for IOS #48788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grgia opened this issue Sep 9, 2024 · 101 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Sep 9, 2024

Description

This is a tracking issue for the IOS implementation of the Native Share project. This section of the project will be handled separately but merged alongside the Android issue.

Project

https://docs.google.com/document/d/14C1VifxvIXeyLAf0XstbC-wvyAb5SQZ0AOw0-jLRyZs/edit

Tracking

#36613

Issue OwnerCurrent Issue Owner: @sonialiap
@BrtqKr
Copy link
Contributor

BrtqKr commented Sep 9, 2024

Hey, I'm from SWM, I'd like to take care of this issue.

Copy link

melvin-bot bot commented Sep 12, 2024

@grgia, @BrtqKr Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Sep 16, 2024

@grgia, @BrtqKr 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Sep 18, 2024

@grgia, @BrtqKr 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Sep 20, 2024

@grgia, @BrtqKr 10 days overdue. Is anyone even seeing these? Hello?

@grgia
Copy link
Contributor Author

grgia commented Sep 23, 2024

Bumped for update / steps for unblocking permissions

@BrtqKr
Copy link
Contributor

BrtqKr commented Sep 23, 2024

I am focusing on split navigation atm. I'll try to check the setup whenever it's applied and try to continue whenever the navigation is ready.

@melvin-bot melvin-bot bot removed the Overdue label Sep 23, 2024
Copy link

melvin-bot bot commented Sep 26, 2024

@grgia, @BrtqKr Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2024
@BrtqKr
Copy link
Contributor

BrtqKr commented Sep 30, 2024

Taking care of this atm. I've checked the groups before the weekend and they seemed to work as expected.

@melvin-bot melvin-bot bot removed the Overdue label Sep 30, 2024
@BrtqKr
Copy link
Contributor

BrtqKr commented Sep 30, 2024

Working on the files processing - they are being saved correctly from the share extenbsion, but there's something wrong with retrieving them on the react native side. This might be something related to the permissions, but I'll try to confirm it tomorrow.

@grgia
Copy link
Contributor Author

grgia commented Oct 1, 2024

Thanks @BrtqKr- do you have a draft PR up for your branch?

@BrtqKr
Copy link
Contributor

BrtqKr commented Oct 1, 2024

Not yet, wired it up though and the files are being passed to the react native wihthout any issues, so happily there's no need for the additional set-ups. I'll be verifying the scanning/sending with the passed files tomorrow, so this would probably be the initial version for the ios. I'll share more details next evening.

@BrtqKr
Copy link
Contributor

BrtqKr commented Oct 2, 2024

Moving forward with that - wired up most of the js parts - I'll continue working on that and the files cleanup after sharing tomorrow

@grgia
Copy link
Contributor Author

grgia commented Oct 3, 2024

Sounds great, thanks @BrtqKr

@BrtqKr
Copy link
Contributor

BrtqKr commented Oct 3, 2024

Still working on the JS part - today it was mostly persistence and onyx-related things, which are necessary for removing files - it's not done yet though

@BrtqKr
Copy link
Contributor

BrtqKr commented Oct 4, 2024

Continued the topic from yesterday. I've found some edge cases about the cleanup part - there's an issue when the share attempt gets cancelled and the file isn't removed properly, but we can handle this by performing cleanups for the files older than a week. Besides I had to slightly modify the model for the image, but apply small updates to the doc when I'm sure everything works.

@grgia
Copy link
Contributor Author

grgia commented Oct 7, 2024

Great @BrtqKr, do you have an idea for when we might be able to get this into the review stage?

@melvin-bot melvin-bot bot added the Overdue label Oct 7, 2024
@BrtqKr
Copy link
Contributor

BrtqKr commented Oct 8, 2024

@grgia, I've finished wiring up the core version for the ios today. Also, @filip-solecki mentioned that there wasn't much left regarding the Android native part, so I'd say that the remaining things before the PR would be:

  1. Adjust the data format on Android to match the ios (I had to slightly change the format to handle some cases on the react-native side)
  2. Finish the file removal
  3. Adjust the display for the files
  4. Pass to @staszekscp and @war-in to apply the hybrid app-related changes and test it properly

The first three points shouldn't take much time since those are just the follow-ups to the already existing parts (the second point is a bit troublesome to test though). I'm not sure about the fourth point. As long as everything goes as expected on the hybrid part we should be able to send the final version sometime at the beginning the next week, but this is something @staszekscp or @war-in would need to estimate when they start applying the changes.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-08.at.02.19.43.mp4

@melvin-bot melvin-bot bot removed the Overdue label Oct 8, 2024
@filip-solecki
Copy link
Contributor

Hi! Quick update - I took the issue from @BrtqKr and I'll work on both right now as JS part will be shared for both Android and iOS

@melvin-bot melvin-bot bot changed the title [Due for payment 2025-02-18] [Native Share] Implement Native Share for IOS [Due for payment 2025-03-28] [Due for payment 2025-02-18] [Native Share] Implement Native Share for IOS Mar 21, 2025
Copy link

melvin-bot bot commented Mar 21, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 21, 2025
Copy link

melvin-bot bot commented Mar 21, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.16-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-28. 🎊

For reference, here are some details about the assignees on this issue:

  • @BrtqKr does not require payment (Contractor)
  • @cdOut requires payment (Needs manual offer from BZ)
  • @filip-solecki does not require payment (Contractor)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Mar 24, 2025
Copy link

melvin-bot bot commented Mar 25, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Mar 25, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Mar 25, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Mar 26, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-03-28] [Due for payment 2025-02-18] [Native Share] Implement Native Share for IOS [Due for payment 2025-04-02] [Due for payment 2025-03-28] [Due for payment 2025-02-18] [Native Share] Implement Native Share for IOS Mar 26, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 26, 2025
Copy link

melvin-bot bot commented Mar 26, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 26, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.18-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-02. 🎊

For reference, here are some details about the assignees on this issue:

  • @BrtqKr does not require payment (Contractor)
  • @cdOut requires payment (Needs manual offer from BZ)
  • @filip-solecki does not require payment (Contractor)

@grgia
Copy link
Contributor Author

grgia commented Mar 28, 2025

In regression period

Copy link

melvin-bot bot commented Apr 2, 2025

Payment Summary

Upwork Job

  • Contributor: @BrtqKr is from an agency-contributor and not due payment
  • ROLE: @cdOut paid $(AMOUNT) via Upwork (LINK)
  • Contributor: @filip-solecki is from an agency-contributor and not due payment

BugZero Checklist (@sonialiap)

  • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Apr 3, 2025
@sonialiap
Copy link
Contributor

@grgia I see this got linked to a few deploy blockers, did this cause any regressions?

@melvin-bot melvin-bot bot removed the Overdue label Apr 7, 2025
@grgia
Copy link
Contributor Author

grgia commented Apr 7, 2025

@sonialiap no regressions!

@sonialiap
Copy link
Contributor

Thanks!

@sonialiap
Copy link
Contributor

Payment summary:

  • All three engineers are from SWM so no payment needed (I trusted melvin about cdOut needing a manual offer, but was lead astray 😂)

Since this is a new feature, most of the checklist is not relevant

@grgia grgia reopened this Apr 29, 2025
@grgia
Copy link
Contributor Author

grgia commented Apr 29, 2025

@sonialiap I think we forgot to handle the payout for @shubham1206agra's C+ review. Would you please help with $500 review payment for this PR? #58834

@sonialiap
Copy link
Contributor

Thanks for reopening!

Payment summary:

@garrettmknight
Copy link
Contributor

$500 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants