Migrate Reports page to use it's own FlatList #57549

SzymczakJ · 2025-02-27T16:23:14Z

Explanation of Change

This PR removes SelectionList from Reports Page, as it introduces a lot of unnecessary calculation and creates a lot of performance issues. Instead of that we use FlatList with some of the necessary features of SelectionList like "moving through items with keyboard" or "scolling to and highliting an item". I carefully moved them to a new component SearchList which greatly helps with performance.

I made some benchmarks between the old version of Reports screen and new version, I was measuring total time spent on calculating rerenders(and useEffects/useLayoutEffects) caused by entering Reports Page and also number of total commits. I made these benchmarks for iOS and Android platforms, as they the biggest performance problems and I was measuring it on emulator/simulator.

Old version:

Total time/number of commits spent on calculating rerenders:

Android:

First enter: ~3873 ms/ ~36 commits
Following enter: ~3521 ms / ~32 commits

iOS:

First enter: 4393 ms/ ~27 commits
Following enter: ~4556 ms / ~27 commits

New version:

Total time/number of commits spent on calculating rerenders:

Android:

First enter: ~2521 ms/ ~19 commits
Following enter: ~2112 ms / ~16 commits

iOS:

First enter: 2922 ms/ ~20 commits
Following enter: ~2772 ms / ~16 commits

Fixed Issues

$ #57191
$ #57069
$ #57170
PROPOSAL:

Tests

Test common list features like(scrolling, refetching on end reached, etc.)
Test selection feature on Reports page.
Test, if cliciking on report opens up a report
Test, if quick actions like "Pay" work, when they are triggered by clicking on list item button.
On desktop, test if going through items with arrows/keyboard is working.
Test, if highlighting works.

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-02-27T16:23:25Z

⚠️ This PR is possibly changing native code, it may cause problems with HybridApp. Please run an AdHoc build to verify that HybridApp will not break. ⚠️

github-actions · 2025-03-04T14:16:13Z

⚠️ This PR is possibly changing native code, it may cause problems with HybridApp. Please run an AdHoc build to verify that HybridApp will not break. ⚠️

github-actions · 2025-03-07T15:40:06Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-03-11T14:31:35Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

blazejkustra

Overall, the refactor looks very solid! Tested it on web and I instantly see the difference 👍

I think that selecting all items doesn't work atm @SzymczakJ

src/components/Search/SearchList.tsx

blazejkustra · 2025-03-11T15:13:44Z

src/components/Search/SearchList.tsx

+    shouldPreventDefaultFocusOnSelectRow?: boolean;
+};
+
+function SearchList(


This component looks much cleaner than its counterpart (SelectionList). Great refactor! 🚀

…on-list

melvin-bot · 2025-03-12T12:02:42Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ikevin127 · 2025-03-12T19:58:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

android-mweb.webm

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-mweb.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

luacmartins

LGTM and tests well

luacmartins · 2025-03-12T20:01:46Z

@SzymczakJ we have conflicts

… input

luacmartins · 2025-03-13T15:28:52Z

Discussed 1:1 with @SzymczakJ and we decided to wait merging this PR until he's back from ooo, in case there are deploy blockers and we don't have the capacity to fix them.

SzymczakJ · 2025-03-14T16:50:43Z

FYI I'll be OOO for the next week and I'll be back on 25.03.2025, then we can merge ASAP!

SzymczakJ · 2025-03-25T15:16:01Z

I've retested this PR and made sure it's still helping with the performance 😄, the results are simillar.
I think we are ready to merge @luacmartins!

luacmartins · 2025-03-25T16:41:05Z

Merged! Nice work

OSBotify · 2025-03-25T16:47:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-26T06:13:09Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.19-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-27T13:30:18Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.19-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

ikevin127 · 2025-03-29T20:53:30Z

src/components/Search/SearchList.tsx

+    const handleLongPressRow = useCallback(
+        (item: SearchListItem) => {
+            // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
+            if (!isSmallScreenWidth || item?.isDisabled || item?.isDisabledCheckbox || !isFocused) {


An early return condition was missing here for chat reports which caused the following regression issue:

[Due for payment 2025-04-03] [$250] Reports - Select option is shown for messages in Chats #59138

this was fixed by passing a new prop shouldPreventLongPressRow when isChat (true) in order to disable long press row functionality.

DylanDylann · 2025-04-08T10:21:40Z

src/components/Search/SearchList.tsx

+
+            return (
+                <ListItem
+                    showTooltip={false}


@ikevin127 @SzymczakJ Coming from #59656, I want to confirm again whether this change is intentional or just a mistake

99% sure this is a mistake

linhvovan29546 · 2025-04-12T10:38:20Z

src/pages/Search/SearchPageNarrow.tsx

@@ -119,7 +119,7 @@ function SearchPageNarrow({queryJSON, policyID, searchName}: SearchPageNarrowPro
            testID={SearchPageNarrow.displayName}
            shouldEnableMaxHeight
            offlineIndicatorStyle={styles.mtAuto}
-            bottomContent={<BottomTabBar selectedTab={BOTTOM_TABS.SEARCH} />}
+            bottomContent={!searchRouterListVisible && <BottomTabBar selectedTab={BOTTOM_TABS.SEARCH} />}


Hello! @SzymczakJ Could you help confirm what issue this commit fixes? I wasn’t able to identify any specific problem that it resolves. The only thing I noticed is that the bottom tab bar appears above the keyboard on Android mWeb Chrome — but that also happens on production.

Yes, that line was supposed to fix that, but now when I look at it, it was broken by adding TopLevelBottomTabBar to RootNavigatorExtraContent

If you come up with a PR for that, please ping me, because I'm curious how the solution will look like.

Also, could you please link the issue 🙏

@SzymczakJ Yeah, I asked because I saw that it caused this issue: #60017. It looks like reverting it works correctly and resolved the issue above, since it didn’t resolve the issue as mentioned.

ntdiary · 2025-04-23T14:28:32Z

src/components/Search/SearchList.tsx

+                        if (isMobileChrome() && event.nativeEvent && !event.nativeEvent.sourceCapabilities) {
+                            return;
+                        }
+                        setFocusedIndex(index);


App/src/components/SelectionList/index.tsx

Lines 74 to 76 in c3451e1

// Ignore the focus if it's caused by a touch event on mobile chrome.

// For example, a long press will trigger a focus event on mobile chrome.

shouldIgnoreFocus={isMobileChrome() && isScreenTouched}

This edge case was missed during the migration, we fixed it in issue #59420. :)

put FlashList on Reports page

15940e0

implement BaseSelectionList functionalities in SearchList

b5935a6

SzymczakJ added 2 commits March 7, 2025 12:55

Merge branch 'main' into @szymczak/reports-screen-without-selection-list

072832a

add missing functionalities to SearchList

17e6ec8

SzymczakJ added 2 commits March 11, 2025 13:53

fix group report selection bug

73582e5

Merge branch 'main' into @szymczak/reports-screen-without-selection-list

84c3f69

clean up code

207d8d1

SzymczakJ force-pushed the @szymczak/reports-screen-without-selection-list branch from 4d3496f to 207d8d1 Compare March 11, 2025 14:36

blazejkustra suggested changes Mar 11, 2025

View reviewed changes

luacmartins mentioned this pull request Mar 11, 2025

[Due for payment 2025-04-03] Reports - Search input is slow to expand when opening the second time onward #57069

Closed

8 tasks

fix PR comments

2f11ac5

SzymczakJ changed the title ~~[WIP] Migrate Reports page to use FlashList~~ [WIP] Migrate Reports page to use it's own FlatList Mar 12, 2025

SzymczakJ changed the title ~~[WIP] Migrate Reports page to use it's own FlatList~~ Migrate Reports page to use it's own FlatList Mar 12, 2025

robiMerge branch 'main' into @szymczak/reports-screen-without-selecti…

9702023

…on-list

SzymczakJ marked this pull request as ready for review March 12, 2025 12:02

SzymczakJ requested review from a team as code owners March 12, 2025 12:02

melvin-bot bot requested a review from ikevin127 March 12, 2025 12:02

melvin-bot bot removed the request for review from a team March 12, 2025 12:02

luacmartins mentioned this pull request Mar 12, 2025

[CRITICAL] Android - Scrolling Expenses Causes White Gaps and Skeleton Loading Issues #55562

Open

8 tasks

luacmartins self-requested a review March 12, 2025 19:45

luacmartins assigned SzymczakJ Mar 12, 2025

luacmartins previously approved these changes Mar 12, 2025

View reviewed changes

SzymczakJ dismissed luacmartins’s stale review via 23b8e4e March 13, 2025 09:06

fix navigation bar is displayed above keyboard when tapping on search…

dc92afa

… input

luacmartins requested a review from blazejkustra March 13, 2025 15:28

luacmartins changed the title ~~Migrate Reports page to use it's own FlatList~~ [HOLD 2025-03-24] Migrate Reports page to use it's own FlatList Mar 13, 2025

luacmartins previously approved these changes Mar 13, 2025

View reviewed changes

SzymczakJ mentioned this pull request Mar 14, 2025

[Due for payment 2025-04-03] mWeb - Reports - Navigation bar is displayed above keyboard when tapping on search input. #57170

Closed

8 tasks

SzymczakJ added 2 commits March 25, 2025 13:56

Merge branch 'main' into @szymczak/reports-screen-without-selection-list

a39e2af

fix wrong imports

4bb7412

SzymczakJ dismissed luacmartins’s stale review via 4bb7412 March 25, 2025 15:10

luacmartins changed the title ~~[HOLD 2025-03-24] Migrate Reports page to use it's own FlatList~~ Migrate Reports page to use it's own FlatList Mar 25, 2025

luacmartins approved these changes Mar 25, 2025

View reviewed changes

luacmartins merged commit 728ebd2 into Expensify:main Mar 25, 2025
18 checks passed

github-actions bot mentioned this pull request Mar 26, 2025

Deploy Checklist: New Expensify 2025-03-26 #59127

Closed

50 tasks

nkdengineer mentioned this pull request Mar 26, 2025

[Due for payment 2025-04-07] [$250] Reports - Select all checkbox is not marked when it is selected #59142

Closed

8 tasks

daledah mentioned this pull request Mar 26, 2025

[Due for payment 2025-04-03] [$250] Reports - Select option is shown for messages in Chats #59138

Closed

8 tasks

melvin-bot bot mentioned this pull request Mar 27, 2025

Follow up for "add search input to mobile search page issue" #57191

Closed

6 tasks

ikevin127 reviewed Mar 29, 2025

View reviewed changes

linhvovan29546 mentioned this pull request Apr 2, 2025

[Due for payment 2025-04-23] [$250] mWeb - Reports - With multiple expenses long pressing 1st expense page moves & select option shown #59420

Closed

8 tasks

perunt mentioned this pull request Apr 7, 2025

Expenses list performance #56884

Closed

50 tasks

DylanDylann reviewed Apr 8, 2025

View reviewed changes

DylanDylann mentioned this pull request Apr 8, 2025

[Due for payment 2025-04-18] [$250] Web - Reports - No tooltip when hovering over avatar in Reports > Chats #59656

Closed

8 tasks

linhvovan29546 reviewed Apr 12, 2025

View reviewed changes

ntdiary reviewed Apr 23, 2025

View reviewed changes

	// Ignore the focus if it's caused by a touch event on mobile chrome.
	// For example, a long press will trigger a focus event on mobile chrome.
	shouldIgnoreFocus={isMobileChrome() && isScreenTouched}

Migrate Reports page to use it's own FlatList #57549

Migrate Reports page to use it's own FlatList #57549

Uh oh!

Conversation

SzymczakJ commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Old version:

New version:

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Feb 27, 2025

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 7, 2025

Uh oh!

github-actions bot commented Mar 11, 2025

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 12, 2025

Uh oh!

ikevin127 commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Mar 12, 2025

Uh oh!

luacmartins commented Mar 13, 2025

Uh oh!

SzymczakJ commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SzymczakJ commented Mar 25, 2025

Uh oh!

Uh oh!

luacmartins commented Mar 25, 2025

Uh oh!

OSBotify commented Mar 25, 2025

Uh oh!

github-actions bot commented Mar 26, 2025

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

SzymczakJ commented Feb 27, 2025 •

edited

Loading

ikevin127 commented Mar 12, 2025 •

edited

Loading

SzymczakJ commented Mar 14, 2025 •

edited

Loading