Follow up for "add search input to mobile search page issue"

[SzymczakJ]

This is group issue for all the follow-ups of add search input to mobile search page issue PR.
What needs to be done?

• iOS - Search - Unable to double tap on the search field to highlight it
• design change - fadeIn/Out of the content
• design change - flicker of bookmark button
• boost Reports page performance [Due for payment 2025-04-03] Reports - Search input is slow to expand when opening the second time onward #57069
• Search autocomplete list not visible [CP Staging] fix blank area and status bar #57113 (comment)
• [Due for payment 2025-04-03] mWeb - Reports - Navigation bar is displayed above keyboard when tapping on search input. #57170

cc @luacmartins

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@luacmartins, @NicMendonca, @ikevin127, @SzymczakJ Whoops! This issue is 2 days overdue. Let's get this updated quick!

[SzymczakJ]

WIP, I started looking at the performance of Reports page.

[SzymczakJ]

Update: I'm testing out an option to replace SelectionList(from our Search/index.tsx component) with a FlashList. Writing a small POC to check. if it's even doable and what performance gains it might give us.

[SzymczakJ]

I've done measurements with React Native dev tools profiler:
I've measured the total count of react commits that are caused by navigating for the first time to Reports page and I also summed the total render time(plus time spent on running useEffects and useLayoutEffects)
These are the results:
Old version: total commits ~35, total time: ~4000 ms
New version using flash list: total commits: ~23-24, total time ~1500ms
Selection list implements many functionalities(and a lot of them are not performant) that Reports page doesn't need and that's the main reason using Flash list helps so much.

I don't have all of the functionalities implemented yet(like selecting items with arrows), so the total time of the new approach will be higher, but I still think this will be tremendous upgrade in the Reports page performance. WDYT of this @luacmartins. Migrating this fully will take some time(probably the draft should be ready next week), so I need your green light to continue 😄

[luacmartins]

That seems promising. Do you have a POC I can take a look at?

[SzymczakJ]

Here's a small POC ⬆

[luacmartins]

@SzymczakJ I just wanted to bring this other PR that's also aiming to improve the performance of Search

[SzymczakJ]

Thanks for mentioning that. We're lucky and our PRs optimise other things, so both of them are valuable 😄. If you see any other performance fixes for Search, please let me know!
I'm also pretty close to having full functionality of SelectionList in my new FlashList.

[luacmartins]

Nice! Let's keep it up!

[melvin-bot]

@luacmartins @NicMendonca @ikevin127 @SzymczakJ this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[SzymczakJ]

Update PR ready for review, here are some outcomes of it:

I made benchmarks between the old version of Reports screen and new version, I was measuring total time spent on calculating rerenders(and useEffects/useLayoutEffects) caused by entering Reports Page and also number of total commits. I made these benchmarks for iOS and Android platforms, as they the biggest performance problems and I was measuring it on emulator/simulator.

Old version:
Total time/number of commits spent on calculating rerenders:

Android:
First enter: ~3873 ms/ ~36 commits
Following enter: ~3521 ms / ~32 commits
iOS:
First enter: 4393 ms/ ~27 commits
Following enter: ~4556 ms / ~27 commits
New version:
Total time/number of commits spent on calculating rerenders:

Android:
First enter: ~2521 ms/ ~19 commits
Following enter: ~2112 ms / ~16 commits
iOS:
First enter: 2922 ms/ ~20 commits
Following enter: ~2772 ms / ~16 commits

This is not a complete fix for performance issue, but it's a big step for us and it should help with all the animations being slow, etc.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Migrate Reports page to use it's own FlatList #57549

If no regressions arise, payment will be issued on 2025-04-03. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment (Needs manual offer from BZ)
• @SzymczakJ does not require payment (Contractor)

[melvin-bot]

@ikevin127 @NicMendonca @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[SzymczakJ]

Since not every issue from this group issue wasn't completed yet I suggest to not close this task, but to put it on weekly. When we are done with Traditional Reports feature I will have some time to work on rest of these issues and finish them.
WDYT @luacmartins

[luacmartins]

Sounds good to me

[ikevin127]

@NicMendonca No payment action required here for me, payment for #57191 (comment) will be handled in the regression issue where I'll get -50% of the bounty.

[NicMendonca]

Not overdue

[NicMendonca]

Not overdue

[luacmartins]

I think everything here is done, right?

[SzymczakJ]

It seems so, let's just close this.

[luacmartins]

Thanks for the work everyone!