-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-04-03] Reports - Search input is slow to expand when opening the second time onward #57069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @robertjchen ( |
Triggered auto assignment to @zanyrenney ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
This is an overall performance issue of Reports page which I would rather tackle as a follow-up, therefore can we take out the deploy blocker label @mountiny @luacmartins? |
Hard to say - I guess it depends on how bad it is for the larger accounts and if it makes it basically unusable (compared to production) I dont think we can treat it as a follow up only. I am happy to remove the blocker, but could @puneetlath @JmillsExpensify or someone with lots of reports help to confirm how this works for you in 9.1.1.0 native app? is it usable? could you compare with production? |
Way to access the Search input in the older version of app would be to open SearchRouter by clicking magnifying glass on Reports page, which would also open up a little slower, because it was a global change in contexts and etc.. So when we compare it to the previous version of the app we have a benefit of user directly seeing the Search input, with all the important information, consistency and not waiting to be redirected to Search Router and while it is a little laggy on big accounts it was also laggy before, but in another way(the SearchRouter opening slow). I think that overall it's a better experience. WDYT |
Puneet confirmed here that there are no noticeable performance issues on his account. We'll demote this to NAB and work on a fix as a follow up. |
sounds awesome thank you for the run down @luacmartins ! |
Am i good to follow the existing BZ process then for this one, and get |
Let's see if @SzymczakJ or someone from SWM wants to take this one first since they've been working on Search. If not, we can open it to the community. |
I should be able to start investigating this today/tomorrow. |
Thanks @SzymczakJ |
@SzymczakJ Eep! 4 days overdue now. Issues have feelings too... |
WIP, the PR for speeding up the performance is close to being ready for review, I just have to prioritize other tasks today. I should be able to continue working on this tomorrow. |
@SzymczakJ Huh... This is 4 days overdue. Who can take care of this? |
We're working on it in this PR #57549 |
Awesome, thank you for the update @luacmartins |
Sorry for delayed response, should've linked it earlier. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-04-03. 🎊 For reference, here are some details about the assignees on this issue:
|
@luacmartins @zanyrenney @SzymczakJ The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
Closing since there is no payment summary. |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.1.0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Search
Action Performed:
Precondition:
Expected Result:
The search input will expand immediately.
Actual Result:
The search input is slow to expand when opening the second time onward
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6747429_1739937795057.ScreenRecording_02-19-2025_12-00-24_1.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @zanyrenneyThe text was updated successfully, but these errors were encountered: