Skip to content

[Due for payment 2025-04-03] Reports - Search input is slow to expand when opening the second time onward #57069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 8 tasks
mitarachim opened this issue Feb 19, 2025 · 29 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

mitarachim commented Feb 19, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.1.0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Search

Action Performed:

Precondition:

  • Account has many contacts (Expensifail account).
  1. Launch ND or hybrid app.
  2. Go to Reports.
  3. Tap on the search input.
  4. Tap Cancel.
  5. Tap on the search input again.

Expected Result:

The search input will expand immediately.

Actual Result:

The search input is slow to expand when opening the second time onward

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6747429_1739937795057.ScreenRecording_02-19-2025_12-00-24_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @zanyrenney
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Feb 19, 2025
Copy link

melvin-bot bot commented Feb 19, 2025

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 19, 2025

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 19, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 19, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@SzymczakJ
Copy link
Contributor

This is an overall performance issue of Reports page which I would rather tackle as a follow-up, therefore can we take out the deploy blocker label @mountiny @luacmartins?
Due to how heavy is the Reports page on a big accounts, it takes time to render everything and it makes layout animation(which is the only animation type that works smooth) to be postponed in time. What's more every action that user does with really small time-in-between, will lag on big accounts like navigating between screens(Reports and Chat). That's why we need some time to investigate.

@mountiny
Copy link
Contributor

Hard to say - I guess it depends on how bad it is for the larger accounts and if it makes it basically unusable (compared to production) I dont think we can treat it as a follow up only.

I am happy to remove the blocker, but could @puneetlath @JmillsExpensify or someone with lots of reports help to confirm how this works for you in 9.1.1.0 native app? is it usable? could you compare with production?

@SzymczakJ
Copy link
Contributor

Way to access the Search input in the older version of app would be to open SearchRouter by clicking magnifying glass on Reports page, which would also open up a little slower, because it was a global change in contexts and etc..

So when we compare it to the previous version of the app we have a benefit of user directly seeing the Search input, with all the important information, consistency and not waiting to be redirected to Search Router and while it is a little laggy on big accounts it was also laggy before, but in another way(the SearchRouter opening slow). I think that overall it's a better experience. WDYT

@luacmartins
Copy link
Contributor

luacmartins commented Feb 19, 2025

Puneet confirmed here that there are no noticeable performance issues on his account. We'll demote this to NAB and work on a fix as a follow up.

@luacmartins luacmartins removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Feb 19, 2025
@luacmartins luacmartins added Daily KSv2 and removed Hourly KSv2 labels Feb 19, 2025
@zanyrenney
Copy link
Contributor

sounds awesome thank you for the run down @luacmartins !

@zanyrenney
Copy link
Contributor

Am i good to follow the existing BZ process then for this one, and get external added so this can be worked on by our C/C+ team?

@luacmartins
Copy link
Contributor

Let's see if @SzymczakJ or someone from SWM wants to take this one first since they've been working on Search. If not, we can open it to the community.

@SzymczakJ
Copy link
Contributor

I should be able to start investigating this today/tomorrow.

@luacmartins
Copy link
Contributor

Thanks @SzymczakJ

Copy link

melvin-bot bot commented Mar 5, 2025

@SzymczakJ Eep! 4 days overdue now. Issues have feelings too...

@SzymczakJ
Copy link
Contributor

SzymczakJ commented Mar 5, 2025

WIP, the PR for speeding up the performance is close to being ready for review, I just have to prioritize other tasks today. I should be able to continue working on this tomorrow.

Copy link

melvin-bot bot commented Mar 11, 2025

@SzymczakJ Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2025
@luacmartins
Copy link
Contributor

We're working on it in this PR #57549

@zanyrenney
Copy link
Contributor

Awesome, thank you for the update @luacmartins

@SzymczakJ
Copy link
Contributor

Sorry for delayed response, should've linked it earlier.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Mar 11, 2025
Copy link

melvin-bot bot commented Mar 26, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Mar 26, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 27, 2025
@melvin-bot melvin-bot bot changed the title Reports - Search input is slow to expand when opening the second time onward [Due for payment 2025-04-03] Reports - Search input is slow to expand when opening the second time onward Mar 27, 2025
Copy link

melvin-bot bot commented Mar 27, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 27, 2025
Copy link

melvin-bot bot commented Mar 27, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-03. 🎊

For reference, here are some details about the assignees on this issue:

  • @SzymczakJ does not require payment (Contractor)

Copy link

melvin-bot bot commented Mar 27, 2025

@luacmartins @zanyrenney @SzymczakJ The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 3, 2025
Copy link

melvin-bot bot commented Apr 3, 2025

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@zanyrenney
Copy link
Contributor

Closing since there is no payment summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
Status: Done
Development

No branches or pull requests

6 participants