[Due for payment 2025-04-07] [$250] Reports - Select all checkbox is not marked when it is selected

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.19-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

Precondition:

• Have at least one expense.

1. Go to staging.new.expensify.com
2. Go to Reports.
3. Go to Expense Reports.
4. Click Select all checkbox.

Expected Result:

Select all checkbox will be marked.

Actual Result:

Select all checkbox is not marked when it is selected.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6782562_1742982426153.20250326_174537.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904839520100678307
• Upwork Job ID: 1904839520100678307
• Last Price Increase: 2025-03-26
• Automatic offers:
• nkdengineer | Contributor | 106675998

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @inimaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Gonals]

Not a backend blocker

[inimaga]

Frontend issue so adding an external label.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021904839520100678307

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot]

Current assignee @hoangzinh is eligible for the External assigner, not assigning anyone new.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-26 10:40:45 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Select all checkbox is not marked when it is selected.

What is the root cause of that problem?

We detected the checkbox is checked if selectedItemsLength === data.length but in this case, it's not. The data.length contains a policyExpenseChat report with no transaction.

App/src/components/Search/SearchList.tsx

Line 301 in 83994af

isChecked={selectedItemsLength === data.length}

We can't see it in the UI because we return early here if reportItem.transactions.length === 0

App/src/components/SelectionList/Search/ReportListItem.tsx

Lines 82 to 84 in 83994af

	if (reportItem.transactions.length === 0) {
	return;
	}

What changes do you think we should make in order to solve the problem?

We should filter out the report that doesn't have any transaction here

return Object.values(reportIDToTransactions).filter((report) => report.transactions.length);

App/src/libs/SearchUIUtils.ts

Line 517 in 83994af

return Object.values(reportIDToTransactions);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Or we can update the way to detect the isChecked by filtering out the data that doesn't have any transaction if the type is expense

App/src/components/Search/SearchList.tsx

Line 301 in 83994af

isChecked={selectedItemsLength === data.length}

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[hoangzinh]

@nkdengineer can you find the offending PR of this DB?

[nkdengineer]

@hoangzinh It comes from #57549.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[inimaga]

Proposal looks good to me too. So assigned now.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: select all checkbox is not marked when it is selected #59153

If no regressions arise, payment will be issued on 2025-04-03. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@hoangzinh @VictoriaExpensify @hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.20-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: select all checkbox is not marked when it is selected #59153

If no regressions arise, payment will be issued on 2025-04-07. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@hoangzinh @VictoriaExpensify @hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[VictoriaExpensify]

Payment summary:
Contributor: @nkdengineer owed $250 via NewDot
C+: @hoangzinh paid $250 via Upwork

[hoangzinh]

Requested payment in ND

[garrettmknight]

$250 approved for @hoangzinh