Skip to content

[Due for payment 2025-05-22] Global VBBA follow-up with fixes and improvements #60633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
13 tasks done
MrMuzyk opened this issue Apr 22, 2025 · 5 comments
Open
13 tasks done
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2

Comments

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Apr 22, 2025

After initial round of testing for accounts that have this feature enabled we've got few things to fix and improve.

This issue aim to address them:

Things that were found during testing by us while developing:

  • In the director step the zip also does the American validation so it does not accept canadian zip codes
  • For CAD in the request to SaveCorpayOnboardingDirectorInformation we sent "downloadedPDSandFSG":true. This should only be there for AUD bank accounts Will be fixed in [GR Phase 3] Step 5 - add download button instead of upload file for PRD & FSG on the upload files sub-step #59217
  • In step 3 we should gather business's website address. We should do it for all currencies but only for US and CAD it cant be an empty string
  • Update error message that mentions USD only - Oops! It appears that your workspace currency is set to a different currency than USD... Skipping this one for now. Will be updated later
@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Apr 22, 2025

@madmax330 If you could be so kind and assign me and @hungvu193 to this issue. Thanks 🙇

@madmax330 madmax330 added the Weekly KSv2 label Apr 22, 2025
@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Apr 24, 2025

Draft for this issue is up. Doing my best to include solution to each issue in separate commits.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Apr 30, 2025
@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Apr 30, 2025

We as a Callstack have a next couple of days off due to public holidays. I'll be back on 05.05.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 15, 2025
@melvin-bot melvin-bot bot changed the title Global VBBA follow-up with fixes and improvements [Due for payment 2025-05-22] Global VBBA follow-up with fixes and improvements May 15, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 15, 2025
Copy link

melvin-bot bot commented May 15, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 15, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-22. 🎊

For reference, here are some details about the assignees on this issue:

  • @hungvu193 requires payment through NewDot Manual Requests
  • @MrMuzyk does not require payment (Contractor)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants