[Due for payment 2025-05-22] [$250] Bank account - RHP back button on Business info does not return to Bank info confirmation page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #56931
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Log in with Expensifail account.
• Have a workspace with EUR as default currency.

1. Launch Expensify app.
2. Go to workspace settings > Workflows.
3. Click Connect bank account.
4. Click Connect manually.
5. Click Country field.
6. Select Croatia and click Next.
7. Complete Bank info substeps and reach Bank info confirmation page.
8. Click Confirm.
9. Click RHP back button.
10. Note that app returns to the first substep of Bank info section instead of the previous page which is Bank info confirmation page.
11. Click Next three times to reach Business info steps.
12. Complete all Business info substeps and reach Business info confirmation page.
13. Click Confirm.
14. Click RHP back button.
15. Note that app returns to the previous page which is Business info confirmation page.

Expected Result:

In Step 10, RHP back button on the first substep of Business info step will return to the previous page which is Bank info confirmation page.

Actual Result:

In Step 10, RHP back button on the first substep of Business info step returns to the first substep of Bank info section instead of the previous page which is Bank info confirmation page.

This is inconsistent with Step 15 where RHP back button on Owner info page returns to Business info confirmation page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6806819_1745019095938.20250419_072005.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021914413513155545543
• Upwork Job ID: 1914413513155545543
• Last Price Increase: 2025-04-21

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[hungvu193]

Not a blocker. GR is under beta. @mitarachim Can you confirm you can connect EUR bank account with brand new account?

[mitarachim]

Hello @hungvu193 , i end up in Hang tight... page while connect EUR bank account

Screen.Recording.2025-04-19.at.8.53.39.AM.mp4

[hungvu193]

Hello @hungvu193 , i end up in Hang tight... page while connect EUR bank account

Screen.Recording.2025-04-19.at.8.53.39.AM.mp4

Oh looks like your account is under beta.
Yes this expected if you don't add director/senior information at step 5. It's under progress, we're working on it

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account - RHP back button on Business info does not return to Bank info confirmation page

What is the root cause of that problem?

When we connect to bank using NON-USD currency, we have some few steps screens and each screen will have some substeps which is:

• Country >> 1 substep screen (country selection)
• BankInfo >> 3 substep screen (bank account & account holder details & confirmation)
• BusinessInfo >> 10 substep screen (name, address, contact info, ...etc)
• More...

When we complete each screen for example in this case BankInfo, we will get redirected to BusinessInfo and when we press the go back button we will redirect back the user to BankInfo

App/src/pages/ReimbursementAccount/NonUSD/NonUSDVerifiedBankAccountFlow.tsx

Lines 63 to 65 in 8ed9c09

	case CONST.NON_USD_BANK_ACCOUNT.STEP.BUSINESS_INFO:
	setNonUSDBankAccountStep(CONST.NON_USD_BANK_ACCOUNT.STEP.BANK_INFO);
	break;

But why after we press the back button in BusinessInfo step we got redirected to BankInfo into the first substep screen?, actually we already have a logic right here to handle this cases which we will show the substep screen to the user based on the provided data information by the user earlier startFrom

App/src/pages/ReimbursementAccount/NonUSD/BankInfo/BankInfo.tsx

Lines 43 to 45 in 8ed9c09

	const inputKeys = getInputKeysForBankInfoStep(corpayFields);
	const values = useMemo(() => getBankInfoStepValues(inputKeys, reimbursementAccountDraft, reimbursementAccount), [inputKeys, reimbursementAccount, reimbursementAccountDraft]);
	const startFrom = getInitialSubStepForBankInfoStep(values, corpayFields);

App/src/pages/ReimbursementAccount/NonUSD/BankInfo/BankInfo.tsx

Lines 77 to 85 in 8ed9c09

	const {
	componentToRender: SubStep,
	isEditing,
	screenIndex,
	nextScreen,
	prevScreen,
	moveTo,
	goToTheLastStep,
	} = useSubStep<BankInfoSubStepProps>({bodyContent, startFrom, onFinished: submit});

But the startFrom variable is depends on corpayFields value which is only retrieved from BE

App/src/pages/ReimbursementAccount/NonUSD/BankInfo/BankInfo.tsx

Line 39 in 8ed9c09

const [corpayFields] = useOnyx(ONYXKEYS.CORPAY_FIELDS, {initWithStoredValues: false, canBeMissing: true});

But in this case why we fail to calculate to correct index of substep screens?, as I said the startFrom is depends on corpayFields value which is only retrieved from BE and we also pass initWithStoredValues: false to the useOnyx function

So corpayFields will be undefined unless it needs to wait until GetCorpayBankAccountFields get called which causes this issue, and when we calculate the substep screen index we return 0 right here because corpayFields is undefined, but when GetCorpayBankAccountFields is done,

App/src/pages/ReimbursementAccount/NonUSD/utils/getInitialSubStepForBankInfoStep.ts

Lines 15 to 17 in 8ed9c09

	if (corpayFields === undefined || hasAnyMissingBankAccountDetails) {
	return 0;
	}

What changes do you think we should make in order to solve the problem?

This changes was introduced in this PR #58371, I think maybe there's some issues because corpayFields like very stricts meaning if we change the country or currency, we need to re-call the GetCorpayBankAccountFields, so to avoid any cache data and issues they fix it by adding initWithStoredValues: false which causes this issue

To resolve this issue we can remove this option from the useOnyx method initWithStoredValues: false and whenever the user changes the country/currency we can clear the corpayFields value

Alternatively instead of using useOnyx here for the corpayFields value

App/src/pages/ReimbursementAccount/NonUSD/BankInfo/BankInfo.tsx

Line 39 in 8ed9c09

const [corpayFields] = useOnyx(ONYXKEYS.CORPAY_FIELDS, {initWithStoredValues: false, canBeMissing: true});

App/src/pages/ReimbursementAccount/NonUSD/BankInfo/BankInfo.tsx

Lines 43 to 45 in 8ed9c09

	const inputKeys = getInputKeysForBankInfoStep(corpayFields);
	const values = useMemo(() => getBankInfoStepValues(inputKeys, reimbursementAccountDraft, reimbursementAccount), [inputKeys, reimbursementAccount, reimbursementAccountDraft]);
	const startFrom = getInitialSubStepForBankInfoStep(values, corpayFields);

We can use Onyx.connect inside getInputKeysForBankInfoStep for the corpayFields value

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

[hungvu193]

Also cc @burczu

[yuwenmemon]

Coming from the perspective of the Web Deploy, I removed the DeployBlocker label since this is under beta.

[MrMuzyk]

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

Im also one of the authors of this whole flow this is now behind beta so I have all the needed context.

[marcaaron]

Sounds good!

[MrMuzyk]

Because there were other issues with the flow and they're all relatively small we've decided to fix all of them in one big follow-up issue - #60633

[MrMuzyk]

Draft PR for this and other related issues is up. However I haven't added solution for this particular issue yet

[marcaaron]

Sounds good. Link us the PR here if you can 🙇

[MrMuzyk]

Here it is. I'll be working on fixing this particular issue today :)

[melvin-bot]

@rushatgabhane 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[MrMuzyk]

PR that fixes it just got merged. This will be ready to be retested soon.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Global Reimbursements fixes and improvements #60696

If no regressions arise, payment will be issued on 2025-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @MrMuzyk does not require payment (Contractor)
• @rushatgabhane requires payment through NewDot Manual Requests

[melvin-bot]

@rushatgabhane @OfstadC @rushatgabhane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]