[Due for payment 2025-05-22] [$250] Android - Device back button reopens bank account setup after it is closed via app back button

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #56931
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Workspace Settings

Action Performed:

Precondition:

• Have a workspace with EUR as default currency.
• Log in with Expensifail account.

1. Launch Expensify app.
2. Go to workspace settings > Workflows.
3. Tap Connect bank account.
4. Tap Connect manually.
5. Tap Settings link.
6. Tap app back button three times to return to Settings.
7. Tap device back button.

Expected Result:

App will return to LHN.

Actual Result:

App reopens bank account setup.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6806765_1745013834278.Screen_Recording_20250419_060027_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021914413054452390121
• Upwork Job ID: 1914413054452390121
• Last Price Increase: 2025-04-21
• Automatic offers:
• suneox | Reviewer | 107022664

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[hungvu193]

Not a blocker. GR is under beta

cc @burczu

[yuwenmemon]

Coming from the perspective of the Web Deploy, I removed the DeployBlocker label.

Not a blocker. GR is under beta. cc @burczu

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021914413054452390121

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[MrMuzyk]

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

Im also one of the authors of this whole flow this is now behind beta so I have all the needed context.

[MrMuzyk]

@MrMuzyk what is the ETA for a draft PR on this one? Thanks!

Hopefully today/tomorrow. Because this is not the only issue related to this new flow we've agreed on creating one issue where we'll take care of all the problems - #60633

Draft is up but I havent fixed this particular issue yet - #60696

[MrMuzyk]

@mitarachim @laurenreidexpensify

Hi, I wanted to ask and confirm expected result here. Wouldn't it make more sense for the back arrow on the overview screen to behave the same way that device's back button does? It seems a little bit weird to me that suddenly back arrow doesn't lead user back to previous screen but rather some different path. Video showcasing what I have in mind below.

Screen.Recording.2025-04-25.at.15.00.26.mov

[laurenreidexpensify]

@Expensify/design can you confirm your understanding of the expected pattern here? Thanks

[dannymcclain]

I think we typically want the device back button to work the same as the browser back button, which should also work similarly to the app back button. Having a tough time following this thread, but generally I think I agree with this comment:

Wouldn't it make more sense for the back arrow on the overview screen to behave the same way that device's back button does? It seems a little bit weird to me that suddenly back arrow doesn't lead user back to previous screen but rather some different path.

@Expensify/design for a gut check on that though!

[dubielzyk-expensify]

I think what you have in the video above looks right to me. Generally the Android back button is a back to previous visited screen and a back arrow in the app is up the hierarchy, but in this instance we want them to just sidestep to change the currency and then pop back into the flow to continue connecting their bank account so the video is correct in my view 👍

[MrMuzyk]

I think we typically want the device back button to work the same as the browser back button,

Back button on browser behaves the same way as the device back button on my video I've posted so I will update the android/ios behaviour accordingly.

Thank you for confirmation, working on a fix now.

[laurenreidexpensify]

Thanks @dubielzyk-expensify @dannymcclain 🙇‍♀

[MrMuzyk]

PR that fixes it just got merged. This will be ready to be retested soon.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Global Reimbursements fixes and improvements #60696

If no regressions arise, payment will be issued on 2025-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Reviewer)
• @MrMuzyk does not require payment (Contractor)

[melvin-bot]

@suneox @laurenreidexpensify @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[laurenreidexpensify]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[laurenreidexpensify]

@suneox bump for template to be filled out!

[suneox]

@suneox bump for template to be filled out!

I haven't worked on the PR @hungvu193 will take over this one