Skip to content

[GR Phase 3] Step 5 - add download button instead of upload file for PRD & FSG on the upload files sub-step #59217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
burczu opened this issue Mar 27, 2025 · 14 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@burczu
Copy link
Contributor

burczu commented Mar 27, 2025

Creating separate issue for adding download button for PRD & FSG on the upload files sub-step in step 5 of GR Phase 3 feature. We need this to not to block the whole step 5 implementation while waiting for backend changes etc.

Here's Slack discussion about this change: https://callstack-hq.slack.com/archives/C01GTK53T8Q/p1742975556454339?thread_ts=1742564144.616469&cid=C01GTK53T8Q

@burczu burczu added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Mar 27, 2025
Copy link

melvin-bot bot commented Mar 27, 2025

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@sakluger
Copy link
Contributor

Hey @burczu - how can I help with this one? Is this an internal or external issue, and will you be working on it, or do we need to recruit engineers?

@burczu
Copy link
Contributor Author

burczu commented Mar 28, 2025

Hey @sakluger - this is internal, part of the Global Reimbursement project, and a "sub-issue" of this issue: #50907. I'll be working on this one together with @madmax330, so if you could do all the necessary amendments to this issue it would be appreciated. Thank you.

@sakluger sakluger added the Internal Requires API changes or must be handled by Expensify staff label Mar 28, 2025
@sakluger
Copy link
Contributor

Thanks! I assigned both of you and added to the Global Reimbursement GH project.

@sakluger
Copy link
Contributor

I'm also going to set it to weekly to align it with the issue you linked - let me know if it should be moved back to Daily.

@sakluger sakluger added Weekly KSv2 and removed Daily KSv2 labels Mar 28, 2025
@melvin-bot melvin-bot bot added the Overdue label Apr 7, 2025
@madmax330
Copy link
Contributor

Working on it

Copy link

melvin-bot bot commented Apr 10, 2025

@sakluger @madmax330 @burczu this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Apr 16, 2025
@madmax330
Copy link
Contributor

Working on it

@madmax330
Copy link
Contributor

Same

@melvin-bot melvin-bot bot removed the Overdue label Apr 28, 2025
@sakluger sakluger removed their assignment May 2, 2025
@sakluger sakluger added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels May 2, 2025
Copy link

melvin-bot bot commented May 2, 2025

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 2, 2025
@sakluger sakluger self-assigned this May 2, 2025
@sakluger sakluger added Weekly KSv2 and removed Daily KSv2 labels May 2, 2025
@sakluger
Copy link
Contributor

sakluger commented May 2, 2025

I will be OOO from May 5 - 16, so I have added another BZ member to watch over the issue while I'm out.

@melvin-bot melvin-bot bot added the Overdue label May 12, 2025
@VictoriaExpensify
Copy link
Contributor

Any update here @madmax330 ?

@melvin-bot melvin-bot bot removed the Overdue label May 12, 2025
@madmax330
Copy link
Contributor

The PR for this was merged

@madmax330
Copy link
Contributor

Going to close this, we'll finish tracking this here: #60790

@github-project-automation github-project-automation bot moved this from Second Cohort - HIGH to Done in [#whatsnext] #migrate May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Development

No branches or pull requests

4 participants