Skip to content

Bank account - EUR bank account setup flow can be proceeded with USD bank account setup info #60518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6 of 8 tasks
mitarachim opened this issue Apr 19, 2025 · 25 comments
Open
6 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #56931
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Have a workspace with USD as default currency.
  • Log in with Expensifail account.
  1. Launch Expensify app.
  2. Go to workspace settings > Workflows.
  3. Click Connect bank account.
  4. Click Connect manually.
  5. Enter Bank info, Personal info and Company info steps.
  6. Close the RHP on Business owner page.
  7. Go to Overview.
  8. Click Default currency and change it to EUR.
  9. Go back to Workflows.
  10. Click Connect bank account.
  11. Click Continue setup.
  12. Click app back button and verify the fields until "Confirm currency and country" page.

Expected Result:

In Step 11, app should reset the USD bank account setup flow because USD and EUR bank account setup flows contain different required information.

Actual Result:

In Step 11, app allows user to continue EUR bank acconunt setup using USD bank account setup information.
In Step 12, when returning to previous page during EUR bank account setup, many fields are blank.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6806807_1745017737200.20250419_065654.mp4

View all open jobs on GitHub

@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Apr 19, 2025
Copy link

melvin-bot bot commented Apr 19, 2025

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 19, 2025

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 19, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 19, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@hungvu193
Copy link
Contributor

Not a blocker. GR is under beta

cc @burczu

@robertjchen robertjchen added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels Apr 20, 2025
@MrMuzyk
Copy link
Contributor

MrMuzyk commented Apr 22, 2025

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

Im also one of the authors of this whole flow this is now behind beta so I have all the needed context.

@robertjchen
Copy link
Contributor

thanks @MrMuzyk !

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Apr 24, 2025

Because there were other issues with the flow and they're all relatively small we've decided to fix all of them in one big follow-up issue - #60633

@melvin-bot melvin-bot bot removed the Overdue label Apr 24, 2025
@robertjchen
Copy link
Contributor

thanks, we can consolidate there 👍

@MrMuzyk
Copy link
Contributor

MrMuzyk commented May 5, 2025

On friday @madmax330 did let us know on slack that the issue is fixed and should be deployed today. I'll retest it today/tomorrow

@melvin-bot melvin-bot bot removed the Overdue label May 5, 2025
@CortneyOfstad
Copy link
Contributor

Sounds good @MrMuzyk! If you need any help with testing, please let us know!

@MrMuzyk
Copy link
Contributor

MrMuzyk commented May 7, 2025

Flow gets reset properly when user specifically requests it but when it should happen in the background (on currency change) it still doesn't work. I've let Max know on slack and waiting for further info.

@CortneyOfstad
Copy link
Contributor

Thanks @MrMuzyk!

Copy link

melvin-bot bot commented May 13, 2025

@robertjchen, @burczu, @CortneyOfstad, @MrMuzyk Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MrMuzyk
Copy link
Contributor

MrMuzyk commented May 13, 2025

I'm still waiting on signal from @madmax330 that it's fixed

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 13, 2025
@CortneyOfstad
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 15, 2025
Copy link

melvin-bot bot commented May 19, 2025

@robertjchen, @burczu, @CortneyOfstad, @MrMuzyk Whoops! This issue is 2 days overdue. Let's get this updated quick!

@robertjchen
Copy link
Contributor

I think this is fixed now? cc: @madmax330 🙏

@melvin-bot melvin-bot bot removed the Overdue label May 19, 2025
@CortneyOfstad
Copy link
Contributor

@madmax330 can you confirm? 🤞

@melvin-bot melvin-bot bot added the Overdue label May 23, 2025
@CortneyOfstad
Copy link
Contributor

Dropped Max a DM 👍

@melvin-bot melvin-bot bot removed the Overdue label May 23, 2025
@madmax330
Copy link
Contributor

No this is still not fixed, but I'm working on the PR. Should be done early next week

@robertjchen robertjchen assigned madmax330 and unassigned robertjchen May 27, 2025
@robertjchen
Copy link
Contributor

Thanks Maxence 🙇

@robertjchen robertjchen added Weekly KSv2 and removed Daily KSv2 labels May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
Status: No status
Development

No branches or pull requests

7 participants