Adding logical type to conf thrift

[varant-zlai]

Summary

Adding a field LogicalType to conf thrift, and fixing a typo.

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• New Features

  • Added an optional field for logical type classification to the configuration in the orchestration service API.

• Style

  • Updated a parameter name in a method signature for improved clarity.

[coderabbitai]

Walkthrough

A method parameter was renamed in the Scala planner code for clarity, and an optional logicalType field was added to the Conf struct in the orchestration Thrift API. No other logic or structural changes were introduced.

Changes

File(s)	Change Summary
api/src/main/scala/ai/chronon/api/planner/PlanNode.scala	Renamed method parameter from cons to confs in planConfs.
api/thrift/orchestration.thrift	Added optional logicalType field to Conf struct.

Poem

Code whispers shift, names become clear,
Thrift gains a type, a new field appears.
Small changes made with careful intent,
To make the code just a bit more elegant.
🎉

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 98c616e and 81b610b.

📒 Files selected for processing (2)

• api/src/main/scala/ai/chronon/api/planner/PlanNode.scala (1 hunks)
• api/thrift/orchestration.thrift (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (17)

• GitHub Check: service_tests
• GitHub Check: cloud_gcp_tests
• GitHub Check: cloud_aws_tests
• GitHub Check: service_tests
• GitHub Check: cloud_aws_tests
• GitHub Check: cloud_gcp_tests
• GitHub Check: service_commons_tests
• GitHub Check: api_tests
• GitHub Check: online_tests
• GitHub Check: flink_tests
• GitHub Check: api_tests
• GitHub Check: online_tests
• GitHub Check: aggregator_tests
• GitHub Check: aggregator_tests
• GitHub Check: flink_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (2)

api/thrift/orchestration.thrift (1)

265-265: Added logical type field to Conf struct.

The addition of logicalType field allows classification of configurations by their type. This is a clean, backwards-compatible change.

api/src/main/scala/ai/chronon/api/planner/PlanNode.scala (1)

46-46: Parameter name fix from 'cons' to 'confs'.

Improved parameter naming for clarity.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.