Adding logical type to conf thrift

ezvz · ezvz · commit 7803debb1772 · 2025-05-12T13:25:31.000-04:00
diff --git a/api/src/main/scala/ai/chronon/api/planner/PlanNode.scala b/api/src/main/scala/ai/chronon/api/planner/PlanNode.scala
@@ -43,7 +43,7 @@ object PlanNode {
     .flatMap(tryParsingConf[T])
     .toSeq
 
-  def planConfs[T](cons: Seq[T], planner: Planner[T]): Seq[PlanNode] = ???
+  def planConfs[T](confs: Seq[T], planner: Planner[T]): Seq[PlanNode] = ???
   def generatePlans(compiledFolder: String): Seq[PlanNode] = ???
 
 }
diff --git a/api/thrift/orchestration.thrift b/api/thrift/orchestration.thrift
@@ -262,6 +262,7 @@ struct Conf {
     1: optional string name
     2: optional string hash
     3: optional string contents
+    4: optional LogicalType logicalType
 }
 
 struct DiffRequest {

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ object PlanNode {`
`43`	`43`	`.flatMap(tryParsingConf[T])`
`44`	`44`	`.toSeq`
`45`	`45`
`46`		`- def planConfs[T](cons: Seq[T], planner: Planner[T]): Seq[PlanNode] = ???`
	`46`	`+ def planConfs[T](confs: Seq[T], planner: Planner[T]): Seq[PlanNode] = ???`
`47`	`47`	`def generatePlans(compiledFolder: String): Seq[PlanNode] = ???`
`48`	`48`
`49`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -262,6 +262,7 @@ struct Conf {`
`262`	`262`	`1: optional string name`
`263`	`263`	`2: optional string hash`
`264`	`264`	`3: optional string contents`
	`265`	`+ 4: optional LogicalType logicalType`
`265`	`266`	`}`
`266`	`267`
`267`	`268`	`struct DiffRequest {`