Skip to content

Commit 53a367a

Browse files
varant-zlaiezvz
andauthored
Adding logical type to conf thrift (#763)
## Summary Adding a field `LogicalType` to `conf` thrift, and fixing a typo. ## Checklist - [ ] Added Unit Tests - [x] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added an optional field for logical type classification to the configuration in the orchestration service API. - **Style** - Updated a parameter name in a method signature for improved clarity. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: ezvz <[email protected]>
1 parent 998add7 commit 53a367a

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

api/src/main/scala/ai/chronon/api/planner/PlanNode.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ object PlanNode {
4343
.flatMap(tryParsingConf[T])
4444
.toSeq
4545

46-
def planConfs[T](cons: Seq[T], planner: Planner[T]): Seq[PlanNode] = ???
46+
def planConfs[T](confs: Seq[T], planner: Planner[T]): Seq[PlanNode] = ???
4747
def generatePlans(compiledFolder: String): Seq[PlanNode] = ???
4848

4949
}

api/thrift/orchestration.thrift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ struct Conf {
262262
1: optional string name
263263
2: optional string hash
264264
3: optional string contents
265+
4: optional LogicalType logicalType
265266
}
266267

267268
struct DiffRequest {

0 commit comments

Comments
 (0)