Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1204. Fix disapppearing label editor icon. #1525

Merged
merged 4 commits into from
Apr 25, 2017
Merged

Conversation

miketaylr
Copy link
Member

(and a few tiny cleanup commits as well)

r? @karlcow

Mike Taylor added 4 commits April 24, 2017 22:40
This was happening when an issue was close/opened, but the issue status view
shouldn't be worrying about labels.
(GitHub only returns a unique list, but it's possible for the list
to be non-unique client-side, which can result in jumpy renders.
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working. Very cool.
Thanks @miketaylr

@karlcow karlcow merged commit 58f47fd into master Apr 25, 2017
@karlcow
Copy link
Member

karlcow commented Apr 25, 2017

r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants